Skip to content

Conversation

@nwmac
Copy link
Member

@nwmac nwmac commented Oct 23, 2025

Summary

Fixes #15744

Occurred changes and/or fixed issues

This PR adds the new banner (to be updated).

It also adds to brand metadata to allow the overlaid text to be left-aligned rather than centred - this is now used for the SUSE banner.

We also add the ability to specify a class name that will be added to the banner, so that a brand's stylesheet can customise the style, without defining styles that rely on the particular styles that are used in the dashboard code.

This PT also removes the small style from the banner component - we only show it in 2 places and these will now both use a single default height of 200px. This PR tweaks the styles slightly to ensure that a custom theme style does not get ignored due to CSS specificity rules.

Areas or cases that should be tested

Check homepage banner when the ui-brand is set to suse.

Screenshot/Video

Light Mode:
image

Dark Mode:
image

Note on medium screens, the welcome text overlaps the border of the circle in the image (see the R of Rancher):

Light Mode:
image

Dark Mode:
image

On smaller screen widths, we change the banner centring to left, so the text does not overlay onto the ship part of the image:

Light Mode:
image

Dark Mode:
image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@nwmac nwmac added this to the v2.13.0 milestone Oct 23, 2025
@nwmac nwmac requested review from kwwii and rak-phillip October 23, 2025 17:16
@nwmac nwmac self-assigned this Oct 23, 2025
@nwmac nwmac marked this pull request as ready for review October 25, 2025 16:24
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nwmac . Works as advertised 🙏

@nwmac nwmac merged commit e2ae1c7 into rancher:master Oct 29, 2025
220 of 236 checks passed
@nwmac nwmac deleted the suse-banner-new branch October 29, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SUSE Branding for Prime

2 participants