Skip to content

Conversation

@momesgin
Copy link
Member

@momesgin momesgin commented Oct 24, 2025

Summary

Fixes #15588

Occurred changes and/or fixed issues

Please check the UI requirements added to the issue.

Technical notes summary

  • Update the corresponding formatter for displaying the external and internal ips on the table:InternalExternalIP.vue
  • Updated the model to return the first item rather than the last one
  • Unit tests

Areas or cases that should be tested

Go to Explore > Cluster > Nodes:

  • make sure we display the same external/internal ips that kubectl would return
  • when multiple external/internal ips are available we display the "+{n} more" pill and it works as expected(like how it's been mentioned in the ticket under UI requirements)

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@momesgin momesgin added this to the v2.13.0 milestone Oct 24, 2025
@momesgin momesgin self-assigned this Oct 24, 2025
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InternalExternalP formatter is also used in the cluster detail page; this PR has broken it such that it always shows - / Same as External

I think what needs to happen is for the updated getters to be added to cluster.x-k8s.io.machine model to support rke2/k3s clusters detail page. At a glace it looks like they'd be veeery similar to what you have in the node model already. I think the management.cattle.io.node model is only used for rke1 detail page so we should be ok to leave it alone, but worth double-checking that

Screenshot 2025-10-24 at 4 52 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nodes Page should show all external and internal IPs on the node

2 participants