Clarify monitoring read only role limitations #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/integrations-in-rancher/monitoring-and-alerting/rbac-for-monitoring.md
Show resolved
Hide resolved
alexandreLamarre
approved these changes
Feb 28, 2024
joshmeranda
requested review from
LucasSaintarbor,
btat,
martyav and
sunilarjun
as code owners
Contributor
|
@joshmeranda Does this cover similar ground? #1104 |
Contributor
Author
|
@martyav Similar ground, but I believe they are attempting to clarify different aspects of the docs. |
martyav
suggested changes
Feb 28, 2024
docs/integrations-in-rancher/monitoring-and-alerting/monitoring-and-alerting.md
Outdated
Show resolved
Hide resolved
docs/integrations-in-rancher/monitoring-and-alerting/rbac-for-monitoring.md
Outdated
Show resolved
Hide resolved
..._docs/version-2.7/integrations-in-rancher/monitoring-and-alerting/monitoring-and-alerting.md
Outdated
Show resolved
Hide resolved
..._docs/version-2.8/integrations-in-rancher/monitoring-and-alerting/monitoring-and-alerting.md
Outdated
Show resolved
Hide resolved
...oned_docs/version-2.7/integrations-in-rancher/monitoring-and-alerting/rbac-for-monitoring.md
Outdated
Show resolved
Hide resolved
...oned_docs/version-2.8/integrations-in-rancher/monitoring-and-alerting/rbac-for-monitoring.md
Outdated
Show resolved
Hide resolved
martyav
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rancher/rancher#44552 + rancher/rancher#44177
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main.Description
Add some clarification around monitoring view role, which many users find not-straightforward.
Comments