-
Notifications
You must be signed in to change notification settings - Fork 257
Update azure.md #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
celidon
wants to merge
1
commit into
rancher:main
Choose a base branch
from
celidon:patch-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update azure.md #1494
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -100,7 +100,7 @@ This section is valid only for creating clusters with the in-tree cloud provider | |||||||||||||||||
| <details id="v2.6.0-cloud-provider-config-file"> | ||||||||||||||||||
| <summary>Example Cloud Provider Config</summary> | ||||||||||||||||||
|
|
||||||||||||||||||
| ```yaml | ||||||||||||||||||
| ```yaml | ||||||||||||||||||
| { | ||||||||||||||||||
| "cloud":"AzurePublicCloud", | ||||||||||||||||||
| "tenantId": "YOUR TENANTID HERE", | ||||||||||||||||||
|
|
@@ -120,7 +120,7 @@ This section is valid only for creating clusters with the in-tree cloud provider | |||||||||||||||||
| "useManagedIdentityExtension": false, | ||||||||||||||||||
| "useInstanceMetadata": true | ||||||||||||||||||
| } | ||||||||||||||||||
| ``` | ||||||||||||||||||
| ``` | ||||||||||||||||||
|
|
||||||||||||||||||
| </details> | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -144,7 +144,7 @@ Azure supports reading the cloud config from Kubernetes secrets. The secret is a | |||||||||||||||||
|
|
||||||||||||||||||
| Note that the chart reads the Cloud Provider Config from a given secret name in the `kube-system` namespace. Since Azure reads Kubernetes secrets, RBAC also needs to be configured. An example secret for the Cloud Provider Config is shown below. Modify it as needed and create the secret. | ||||||||||||||||||
|
|
||||||||||||||||||
| ```yaml | ||||||||||||||||||
| ```yaml | ||||||||||||||||||
| # azure-cloud-config.yaml | ||||||||||||||||||
| apiVersion: v1 | ||||||||||||||||||
| kind: Secret | ||||||||||||||||||
|
|
@@ -203,7 +203,7 @@ roleRef: | |||||||||||||||||
| - kind: ServiceAccount | ||||||||||||||||||
| name: azure-cloud-config | ||||||||||||||||||
| namespace: kube-system | ||||||||||||||||||
| ``` | ||||||||||||||||||
| ``` | ||||||||||||||||||
|
|
||||||||||||||||||
| ## Using the Out-of-tree Azure Cloud Provider | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -212,14 +212,18 @@ roleRef: | |||||||||||||||||
|
|
||||||||||||||||||
| 1. Select **External** from the **Cloud Provider** drop-down in the **Cluster Configuration** section. | ||||||||||||||||||
|
|
||||||||||||||||||
| :::note | ||||||||||||||||||
| When setting **Cloud Provider** to **External**, all nodes will automatically be tainted with node.cloudprovider.kubernetes.io/uninitialized=true until the Cloud Provder is installed. It is recommended to deploy the CPI as an add-on job as described below. | ||||||||||||||||||
| ::: | ||||||||||||||||||
|
Comment on lines
+215
to
+217
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Suggestion updates the text to present tense and adds indentation so the note aligns with the text of step 1. |
||||||||||||||||||
|
|
||||||||||||||||||
| 2. Prepare the Cloud Provider Configuration to set it in the next step. Note that Rancher automatically creates a new Network Security Group, Resource Group, Availability Set, Subnet, and Virtual Network. If you already have some or all of these created, you must specify them before creating the cluster. | ||||||||||||||||||
| - Click **Show Advanced** to view or edit these automatically generated names. Your Cloud Provider Configuration **must** match the fields in the **Machine Pools** section. If you have multiple pools, they must all use the same Resource Group, Availability Set, Subnet, Virtual Network, and Network Security Group. | ||||||||||||||||||
|
|
||||||||||||||||||
| 3. Under **Cluster Configuration > Advanced**, click **Add** under **Additional Controller Manager Args** and add this flag: `--configure-cloud-routes=false`. | ||||||||||||||||||
|
|
||||||||||||||||||
| Note that the chart reads the Cloud Provider Config from the secret in the `kube-system` namespace. An example secret for the Cloud Provider Config is shown below. Modify it as needed. Refer to the full list of configuration options in the [upstream docs](https://cloud-provider-azure.sigs.k8s.io/install/configs/). | ||||||||||||||||||
|
|
||||||||||||||||||
| ```yaml | ||||||||||||||||||
| ```yaml | ||||||||||||||||||
| apiVersion: helm.cattle.io/v1 | ||||||||||||||||||
| kind: HelmChart | ||||||||||||||||||
| metadata: | ||||||||||||||||||
|
|
@@ -312,7 +316,7 @@ roleRef: | |||||||||||||||||
| - kind: ServiceAccount | ||||||||||||||||||
| name: azure-cloud-config | ||||||||||||||||||
| namespace: kube-system | ||||||||||||||||||
| ``` | ||||||||||||||||||
| ``` | ||||||||||||||||||
|
|
||||||||||||||||||
| 4. Click **Create** to submit the form and create the cluster. | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the expected rendered output here? This block doesn't seem to have the same missing indentation as the other blocks.
The build is also failing without the existing indentation.