Add required External TLS Traefik configuration. #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After longer than I would like to admit not understanding why I was getting redirect loops, I stumbled upon this: rancher/rancher#31071 and a second issue requesting the documentation be updated with the discovered solution: rancher/rancher#43875 looks like someone added something for using nginx as an ingress to enable the header pass through, so I pretty much just copied the phrasing. the config I am using is from https://docs.k3s.io/helm#customizing-packaged-components-with-helmchartconfig I added the other two RFC1918 subnets before realizing there's an allow all option, but I kinda like this a little better because doesn't trust them from WAN addresses.
linkandzelda91
requested review from
LucasSaintarbor,
btat,
pmkovar and
sunilarjun
as code owners
LucasSaintarbor
requested changes
Sep 22, 2025
Contributor
There was a problem hiding this comment.
@linkandzelda91 Thanks for the PR! Requested some changes and left a question. May you add these changes to the other versions of the docs:
- versioned_docs/version-2.12/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
- versioned_docs/version-2.11/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
- versioned_docs/version-2.10/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
- versioned_docs/version-2.9/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
docs/getting-started/installation-and-upgrade/installation-references/helm-chart-options.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Saintarbor <[email protected]>
Co-authored-by: Lucas Saintarbor <[email protected]>
Co-authored-by: Lucas Saintarbor <[email protected]>
Clarify ingress configuration requirements for load balancers and NGINX.
Added instructions for configuring Ingress with Traefik for external TLS termination and clarified WebSocket connection requirements.
Updated wording for clarity and added instructions for Traefik configuration.
Added instructions for configuring Ingress with Traefik and clarified WebSocket connection requirements.
Clarified requirements for load balancer and added instructions for Traefik configuration.
Author
|
Added the changes to the other docs after accepting the suggested changes and correcting the noted mistake referencing RKE vs K3s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After longer than I would like to admit not understanding why I was getting redirect loops, I stumbled upon this: rancher/rancher#31071
and a second issue requesting the documentation be updated with the discovered solution: rancher/rancher#43875
looks like someone added something for using nginx as an ingress to enable the header pass through, so I pretty much just copied the phrasing. the config I am using is from https://docs.k3s.io/helm#customizing-packaged-components-with-helmchartconfig
I added the other two RFC1918 subnets before realizing there's an allow all option, but I kinda like this a little better because doesn't trust them from WAN addresses.
Fixes #[issue_number]
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Comments