Replace Thrust sequential algorithms with libcu++ ones
#5032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
drop_sequential_algorithm
branch
from
bfc9a82 to
1a35b05
Compare
seunghwak
added
improvement
|
@miscco I don't think RAPIDS should adopt CCCL algorithms until they are publicly exposed. Happy to discuss more offline. |
|
yeah, I will investigate what we can do for the sorting algorithms |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a bit controversial because CCCL currently does not officially expose std::algorithms
On the other hand it lets us replace a ton of thrust algorithms that are much heavier than the std::ones, so that might be a win.
There are two I could not replace,
thrust::sequenceandthrust::copy_ifwith a second input range because there are no std equivalents.Also we currently did not port sorting algorithms because those are ... difficult for device compilation