Draft
Conversation
Remove device_memory_resource base class usage, de-template all resource and adaptor types, replace pointer-based per-device resource APIs with ref-based equivalents, and update all call sites for the new signatures. Part of rapidsai/rmm#2011.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Apr 3, 2026
achirkin
added
improvement
Contributor
|
I assume this can only go in after downstream library PRs are merged (cuvs/cuml/cugraph), right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_memory_resourcebase class usage, de-template all resource and adaptor types, replace pointer-based per-device resource APIs with ref-based equivalentsChanges
Core resource infrastructure
device_memory_resource.hpp: Removeany_resource_bridge(which inherited fromrmm::mr::device_memory_resource), remove allshared_ptr<device_memory_resource>constructor overloads, consolidate toany_resource-only pathdevice_resources.hpp: Remove deprecated constructor takingshared_ptr<device_memory_resource>, updateget_workspace_resource()return type (de-templatedlimiting_resource_adaptor)device_resources_snmg.hpp: Remove stale include, de-templatepool_memory_resourcehandle.hpp: Remove deprecated constructors takingshared_ptr<device_memory_resource>device_resources_manager.hpp: Removeworkspace_mrsvector andset_workspace_memory_resource()API, de-templatepool_mr_tooptional<pool_memory_resource>, removedynamic_castfor upstream type detection, replaceget/set_current_device_resource()with_refvariantsMemory tracking
memory_tracking_resources.hpp: Removedevice_tracking_bridge(inherited fromdevice_memory_resource), useset_current_device_resource_ref()directlyCall sites using
get_workspace_resource()→get_workspace_resource_ref()select_k-inl.cuh,select_radix.cuh,select_warpsort.cuh,sparse/select_k-inl.cuh,bitmap_to_csr.cuh,bitset_to_csr.cuhBenchmarks
benchmark.hpp: De-templatepool_memory_resource, useany_resourcefor RAII restoregather.cu,subsample.cu: Same patternTests
handle.cpp: Dereferencelimiting_resource_adaptor*fordevice_bufferconstructordevice_resources_manager.cpp: Remove workspace-related test code for removed APIsmdarray.cu: Removetest_device_resource_bridge_unwrap(bridge no longer exists)multi_variable_gaussian.cu:get_current_device_resource()→get_current_device_resource_ref()