Update README.rst #253
Open
Update README.rst #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this change. would you be able to update the commit message to something like: please? |
readme: Fix libqt5widgets5 dependency typo Signed-off-by: Yakir Gagnon [email protected]
|
Just curious, is there any reason this didn't get merged...? |
|
I'm happy to reopen and merge this. As from the comment above, would you be able to squash into a single commit and change the commit message to follow the format required? |
|
I didn't get that you wanted me to squash the commits... Feel free to close this if it's not squashed properly. But maybe just fix the typo for future users. |
|
Ok, I will create a new PR separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme: Fix libqt5widgets5 dependency typo
Signed-off-by: Yakir Gagnon [email protected]