Make uncompressed images work with the PyavOutput #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncompressed images are passed to the output by the base Encoder class. We need it to inform the output about the video stream, as other (real) encoders do. Also add a framerate parameter so that you can match the output rate. Some outputs seem to be picky about this, such as v4l2loopback devices. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
uncompressed-fix
branch
from
816c9bd to
fbb1911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncompressed images are passed to the output by the base Encoder class. We need it to inform the output about the video stream, as other (real) encoders do.
Also add a framerate parameter so that you can match the output rate. Some outputs seem to be picky about this, such as v4l2loopback devices.