Skip to content

Add SPARE_IRQs to the SVD #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kilograham merged 4 commits into from
Mar 25, 2025
Merged

Add SPARE_IRQs to the SVD #2271

kilograham merged 4 commits into from
Mar 25, 2025
+98 −6

Conversation

@kilograham
Copy link
Contributor

@kilograham kilograham commented Feb 15, 2025 •
edited
Loading

fixes #1898

@kilograham
Add SPARE_IRQ to RP2350 SVD (note not having an <addresBlock> or on…
fd594af 
…e with a size of zero is not a legal SVD, so including something hopefully harmless
@kilograham
Add SPARE_IRQ definitions to RP2040 intctrl.h, and add assertions on …
5b69b03 
…competing #defines as these were called USER_IRQs in the SDK 1.x
@kilograham kilograham added this to the 2.1.1 milestone Feb 15, 2025
@kilograham
Copy link
Contributor Author

kilograham commented Feb 15, 2025 •
edited
Loading

Note, i have not added the extra IRQs to the RP2040 SVD as i don't know if that is rocking the boat too much (as i'd have to change the numInterrupts)

@kilograham
Copy link
Contributor Author

kilograham commented Feb 15, 2025

cc @jonathanpallant, @pta2002, @jannic

not sure if i want to risk making this change at the last hour for 2.1.1 - LMK... if i don't see lots of happy faces, I'll push it to 2.1.2

lurch
lurch reviewed Feb 15, 2025
View reviewed changes
@kilograham kilograham modified the milestones: 2.1.1, 2.1.2 Feb 18, 2025
@kilograham kilograham mentioned this pull request Feb 18, 2025
Open
@kilograham kilograham modified the milestones: 2.1.2, 2.2.0 Mar 18, 2025
@kilograham
Copy link
Contributor Author

kilograham commented Mar 18, 2025

pushing to 2.2.0 since still no feedback

@jonathanpallant
Copy link

jonathanpallant commented Mar 20, 2025

Looks ok to me

@kilograham kilograham modified the milestones: 2.2.0, 2.1.2 Mar 20, 2025
@kilograham kilograham requested a review from lurch March 22, 2025 23:22
lurch
lurch previously approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this, but it all looks sensible.

@kilograham kilograham requested review from liamfraser and lurch March 24, 2025 22:52
@kilograham kilograham merged commit 39fafaa into develop Mar 25, 2025
8 checks passed
@kilograham kilograham deleted the spare_irq_and_svd branch March 25, 2025 18:14
@hanshuebner hanshuebner mentioned this pull request May 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lurch lurch lurch approved these changes

@Wren6991 Wren6991 Awaiting requested review from Wren6991

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

@liamfraser liamfraser Awaiting requested review from liamfraser

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kilograham @jonathanpallant @lurch @peterharperuk