Add pico_unique_id library to host platform #2751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Dec 4, 2025
| void PICO_WEAK_FUNCTION_IMPL_NAME(pico_get_unique_board_id)(pico_unique_board_id_t *id_out) { | ||
| *id_out = retrieved_id; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Perhaps it's worth adding a comment (either here or in the header file) that explicitly says what pico_get_unique_board_id_string will return for "host" builds?
Contributor
Author
There was a problem hiding this comment.
Yep. I've added comments and removed the static part. If someone wants to get a different ID, they just need to implement their own version of pico_get_unique_board_id, and pico_get_unique_board_id_string will automatically follow suit.
Contributor
There was a problem hiding this comment.
Thanks. But I was suggesting clarifying if (the default implementation of) pico_get_unique_board_id_string returns "A0A1A2A3A4A5A6A7" or "A7A6A5A4A3A2A1A0" 😉
rhulme
force-pushed
the
host_unique_id
branch
from
624bf22 to
cb9ad34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2750