Skip to content

RavenDB-24201: update CI wf according to ansible steering committee's… #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2025
Merged

RavenDB-24201: update CI wf according to ansible steering committee's… #13

merged 1 commit into from
Aug 17, 2025

Conversation

@TheGoldenPlatypus
Copy link
Contributor

@TheGoldenPlatypus TheGoldenPlatypus commented Aug 5, 2025

… review

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 5, 2025
View reviewed changes
.github/workflows/tests_role_ravendb_node.yml
Comment on lines +13 to +53
name: Ansible Sanity Tests
runs-on: ubuntu-latest
container:
image: python:2.7
strategy:
matrix:
include:
- python-version: "3.12"
ansible-core: stable-2.16
- python-version: "3.12"
ansible-core: stable-2.17
- python-version: "3.13"
ansible-core: stable-2.18
- python-version: "3.13"
ansible-core: stable-2.19
- python-version: "3.13"
ansible-core: devel
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Fix collection path for ansible-test # should be removed once we restructure
- name: Fix collection path for ansible-test
run: |
mkdir -p ansible_collections/ravendb/ravendb
tar --exclude=ansible_collections -cf - . | tar -C ansible_collections/ravendb/ravendb -xf -
rsync -av --exclude ansible_collections ./ ansible_collections/ravendb/ravendb
cd ansible_collections/ravendb/ravendb
- name: Set up Python (host)
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install "ansible-core@https://github.com/ansible/ansible/archive/stable-2.9.tar.gz"
pip install "ansible-core@https://github.com/ansible/ansible/archive/${{ matrix.ansible-core }}.tar.gz"
- name: Run ansible-test sanity
working-directory: ansible_collections/ravendb/ravendb
run: |
ansible-test sanity --python 2.7 -v --color
sanity:
name: Ansible Sanity Tests
ansible-test sanity --docker -v --color
integration-and-unit:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium test

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
gotmax23
gotmax23 reviewed Aug 5, 2025
View reviewed changes
.github/workflows/tests_role_ravendb_node.yml Outdated
Comment on lines 121 to 124
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ansible molecule molecule-docker docker
pip install ansible molecule molecule-docker docker ravendb_test_driver
Copy link

@gotmax23 gotmax23 Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should work to make sure the right ansible-core version is installed

      - name: Install dependencies
        env:
          ansible_core_package: "ansible-core @ https://github.com/ansible/ansible/archive/${{ matrix.ansible-core }}.tar.gz"
        run: |
          python -m pip install --upgrade pip
          pip install "${ansible_core_package}" molecule molecule-docker docker ravendb_test_driver

Copy link

@gotmax23 gotmax23 Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe molecule-docker was replaced by molecule-plugins[docker]

Copy link
Contributor Author

@TheGoldenPlatypus TheGoldenPlatypus Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

gotmax23
gotmax23 reviewed Aug 5, 2025
View reviewed changes
.github/workflows/tests_role_ravendb_node.yml
Comment on lines 84 to 86
- python-version: "3.13"
ansible-core: stable-2.19

- python-version: "3.11"
ansible-core: devel
- python-version: "3.12"
ansible-core: devel
- python-version: "3.13"
ansible-core: devel
Copy link

@gotmax23 gotmax23 Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation all looks messed up

Copy link
Contributor Author

@TheGoldenPlatypus TheGoldenPlatypus Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gotmax23
Copy link

gotmax23 commented Aug 5, 2025

Thank you for responding to the feedback on the collection review! I left some comments on this PR.

@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 6 times, most recently from 28aa4e5 to 0f4d628 Compare August 6, 2025 06:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2025
View reviewed changes
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 14 times, most recently from 219711c to 3e0963f Compare August 6, 2025 08:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2025
View reviewed changes
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 4 times, most recently from 8941976 to c1bc9d2 Compare August 6, 2025 08:32
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch from 3b0e3bb to bfb0e18 Compare August 10, 2025 08:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2025
View reviewed changes
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 9 times, most recently from 1430a16 to 2ebbe2d Compare August 10, 2025 08:50
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2025
View reviewed changes
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 4 times, most recently from 4150a17 to 8c940cc Compare August 10, 2025 09:13
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2025
View reviewed changes
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch 2 times, most recently from 548a1f2 to 10fdc67 Compare August 10, 2025 09:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 10, 2025
View reviewed changes
.github/workflows/tests_role_ravendb_node.yml Outdated
Comment on lines 54 to 164

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium test

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
gregolsky
gregolsky reviewed Aug 11, 2025
View reviewed changes
felixfontein
felixfontein approved these changes Aug 13, 2025
View reviewed changes
Copy link

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, LGTM.

.github/workflows/tests_role_ravendb_node.yml Outdated
# required hack, for Molecule to work with Ansible 2.19 or devel
# to be removed once this issue is resolved: https://github.com/ansible-community/molecule-plugins/issues/311
- name: Patch Molecule docker plugin for Ansible 2.19 or devel
Copy link

@felixfontein felixfontein Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that a new molecule-plugins version has been released yesterday (https://github.com/ansible-community/molecule-plugins/releases/tag/v25.8.12) that should fix this issue.

Copy link
Contributor Author

@TheGoldenPlatypus TheGoldenPlatypus Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, done

@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch from 10fdc67 to d927fa0 Compare August 17, 2025 06:16
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-24201_05082051200 branch from d927fa0 to e6429b9 Compare August 17, 2025 06:31
@gregolsky gregolsky merged commit 05b7d4f into main Aug 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregolsky gregolsky gregolsky approved these changes

@gotmax23 gotmax23 Awaiting requested review from gotmax23

+1 more reviewer

@felixfontein felixfontein felixfontein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheGoldenPlatypus @gotmax23 @gregolsky @felixfontein