RavenDB-24937/8: refactor project internals & deploying db to specific nodes & index configuration & index deployment mode #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogy of db , index deployment mode and index configuration features
TheGoldenPlatypus
force-pushed
the
RavenDB-24937/8
branch
from
bc34bf1 to
53906db
Compare
TheGoldenPlatypus
force-pushed
the
RavenDB-24937/8
branch
from
53906db to
e9feed5
Compare
gregolsky
reviewed
Sep 8, 2025
gregolsky
reviewed
Sep 8, 2025
plugins/module_utils/dto/database.py
Outdated
|
|
||
|
|
||
| class DatabaseSpec(object): | ||
| def __init__(self, url, name, replication_factor=1, settings=None, encryption=None, members=None): |
Member
There was a problem hiding this comment.
replication_factor set to 1 by default encourages lack of high availability. RavenDB Studio itself creates the db on all nodes. Can we do this here too?
gregolsky
reviewed
Sep 8, 2025
gregolsky
reviewed
Sep 8, 2025
gregolsky
reviewed
Sep 8, 2025
TheGoldenPlatypus
force-pushed
the
RavenDB-24937/8
branch
from
7034dcd to
4d02a66
Compare
gregolsky
reviewed
Sep 16, 2025
| return ModuleResult.ok(msg=msg.members_would_reconcile(spec.name, to_add, to_remove), changed=True) | ||
| base_msg = msg.members_reconciled(spec.name, to_add, to_remove) | ||
| created = True | ||
| return ModuleResult.error(msg="topology_members is only supported on database creation; modifying an existing database topology is blocked.") |
Member
There was a problem hiding this comment.
Suggested change
| return ModuleResult.error(msg="topology_members is only supported on database creation; modifying an existing database topology is blocked.") | |
| return ModuleResult.error(msg="topology_members is only supported on database creation; modifying an existing database topology is not supported.") |
gregolsky
reviewed
Sep 16, 2025
gregolsky
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.hibernatingrhinos.com/issue/RavenDB-24937/Ansible-add-the-ability-to-deploy-database-to-specific-nodes-only
https://issues.hibernatingrhinos.com/issue/RavenDB-24938/Ansible-add-support-for-rolling-deployment-of-indexes-and-Index-configuration