-
Notifications
You must be signed in to change notification settings - Fork 0
RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules #2
Conversation
009d9a2 to
2ffe4f4
Compare
1271d02 to
6a7df91
Compare
6a7df91 to
dc60dec
Compare
CODE_OF_CONDUCT.md
Outdated
| @@ -0,0 +1,76 @@ | |||
| # Contributor Covenant Code of Conduct | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this one come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a generic one adapted from the Contributor Covenant.
many uses it like the official cisco collection:
https://github.com/ansible-collections/community.ciscosmb/blob/main/CODE_OF_CONDUCT.md
if you prefer it better, we can use just point to Ansible Community Code of Conduct. like in:
https://github.com/ansible-collections/community.dns/blob/main/CODE_OF_CONDUCT.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided to play safe and point to Ansible's COC
| - This module allows you to create or delete a RavenDB database. | ||
| - It supports providing a replication factor and secured connections using certificates. | ||
| - Check mode is supported to simulate database creation or deletion without applying changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be valuable to include a link to https://ravendb.net/docs somewhere in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already present on each module under `seealso', for instance:
https://github.com/ravendb/ansible-collection-ravendb/pull/2/files#diff-da827b3ac7325127211d4ce60c1bda8646b03c124e08f5d6bc93be094b7d5181R73
https://issues.hibernatingrhinos.com/issue/RavenDB-17135/Create-Ansible-module-for-managing-RavenDB
this PR addresses the official collection requirements:
https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_requirements.html