Skip to content

Conversation

@TheGoldenPlatypus
Copy link
Contributor

@TheGoldenPlatypus TheGoldenPlatypus commented Apr 30, 2025

@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-17135_30042025 branch 2 times, most recently from 009d9a2 to 2ffe4f4 Compare April 30, 2025 07:42
@TheGoldenPlatypus TheGoldenPlatypus changed the title RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules WIP RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules Apr 30, 2025
@TheGoldenPlatypus TheGoldenPlatypus force-pushed the RavenDB-17135_30042025 branch 5 times, most recently from 1271d02 to 6a7df91 Compare April 30, 2025 08:28
@TheGoldenPlatypus TheGoldenPlatypus changed the title WIP RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules RavenDB-17135: add sanity wf tests, docs, fix linting and syntax rules Apr 30, 2025
@gregolsky gregolsky self-assigned this Apr 30, 2025
@@ -0,0 +1,76 @@
# Contributor Covenant Code of Conduct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this one come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a generic one adapted from the Contributor Covenant.
many uses it like the official cisco collection:
https://github.com/ansible-collections/community.ciscosmb/blob/main/CODE_OF_CONDUCT.md

if you prefer it better, we can use just point to Ansible Community Code of Conduct. like in:
https://github.com/ansible-collections/community.dns/blob/main/CODE_OF_CONDUCT.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to play safe and point to Ansible's COC

Comment on lines +16 to +18
- This module allows you to create or delete a RavenDB database.
- It supports providing a replication factor and secured connections using certificates.
- Check mode is supported to simulate database creation or deletion without applying changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be valuable to include a link to https://ravendb.net/docs somewhere in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregolsky gregolsky merged commit a412a66 into ravendb:master May 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants