RDBC-959: Add AI agent feature #123

LielNagar · 2025-10-27T11:51:43Z

https://issues.hibernatingrhinos.com/issue/RDBC-959/Sync-Java-client-with-latest-v7.1-AI-features

…son data for tests

garayx · 2025-10-30T08:54:19Z

src/test/java/net/ravendb/client/test/client/documents/AI/AiAgentTests.java

@@ -0,0 +1,180 @@
+package net.ravendb.client.test.client.documents.AI;


can we have test that uses the AiConnectionString ?

duplicated?
#123 (comment)

I put the AI connection strings tests here:
https://github.com/ravendb/ravendb-jvm-client/blob/RDBC-959/src/test/java/net/ravendb/client/documents/operations/ConnectionStringsTest.java

garayx · 2025-10-30T08:55:41Z

src/test/java/net/ravendb/client/test/client/documents/AI/AiAgentTests.java

+                assertThat(e.getMessage())
+                        .contains("Please provide a non-empty value for either outputSchema or sampleObject.");
+            }
+        } catch (Exception e) {


why this try-catch is needed, we have the internal one, no?

the internal is for the test itself, and this one is required because of getDocumentStore which throws Exception. for reference:

ravendb-jvm-client/src/test/java/net/ravendb/client/RemoteTestBase.java

Line 237 in 022fe8f

public DocumentStore getDocumentStore() throws Exception {

garayx · 2025-10-30T09:03:58Z

src/main/java/net/ravendb/client/documents/DocumentStoreBase.java

+    private AiOperations aiOperations;
+
+    @Override
+    public AiOperations getAiOperations(){


should not this be

Suggested change

public AiOperations getAiOperations(){

public AiOperations AI(){

or

Suggested change

public AiOperations getAiOperations(){

public AiOperations ai(){

similar to timeseris, bulkinsert, subscriptions, etc?

garayx · 2025-10-30T09:05:59Z

src/test/java/net/ravendb/client/test/client/documents/AI/AiAgentTests.java

@@ -0,0 +1,180 @@
+package net.ravendb.client.test.client.documents.AI;
+
+import net.ravendb.client.RemoteTestBase;


Can we have tests that uses basic Ai Agent Client Api & real ai connections, see
AiAgentClientApiBasics.cs

done, introduced AiAgentClientApiBasicTest test, in AiAgentTests.java

garayx · 2025-10-30T09:14:54Z

src/main/java/net/ravendb/client/documents/operations/AI/AiAnswer.java

@@ -0,0 +1,31 @@
+package net.ravendb.client.documents.operations.AI;


Please check the folders structure,

for example this file in C# is in
Documents.AI.AiAnswer

you put it in:
documents.operations.AI

lets have same fodlers structure as in C#

garayx · 2025-10-30T09:15:28Z

src/main/java/net/ravendb/client/documents/operations/AI/AiOperations.java

@@ -0,0 +1,93 @@
+package net.ravendb.client.documents.operations.AI;


should be in Documents.AI folder

garayx · 2025-10-30T09:17:09Z

src/main/java/net/ravendb/client/documents/AI/AiOperations.java

+    /**
+     * Creates or updates an AI agent configuration (with the given schema) on the database.
+     */
+    public <TSchema> AiAgentConfigurationResult createAgent(


In C# we have

public AiAgentConfigurationResult CreateAgent(AiAgentConfiguration configuration)

as well

garayx · 2025-10-30T09:18:08Z

src/test/java/net/ravendb/client/test/client/documents/AI/AiAgentTests.java

+            query.setParametersSampleObject("{\"queryName\":\"Example query parameter\"}");
+            agentConfiguration.setQueries(Collections.singletonList(query));
+
+            AddOrUpdateAiAgentOperation createOp = new AddOrUpdateAiAgentOperation(agentConfiguration, null);


Suggested change

AddOrUpdateAiAgentOperation createOp = new AddOrUpdateAiAgentOperation(agentConfiguration, null);

AddOrUpdateAiAgentOperation createOp = new AddOrUpdateAiAgentOperation(agentConfiguration);

garayx · 2025-10-30T09:23:04Z

src/main/java/net/ravendb/client/documents/operations/AI/AiOperations.java

+    /**
+     * Opens an AI conversation for an agent.
+     */
+    public AiConversation conversation(String agentId, String conversationId) {


in C# AiConversationCreationOptions creationOptions is a must parameter

garayx · 2025-11-03T14:46:42Z

src/main/java/net/ravendb/client/documents/AI/AiConversation.java

+        actionResponses.add(new AiAgentActionResponse(toolId, content));
+    }
+
+    public void setUserPrompt(String userPrompt) {


public void AddUserPrompt(params IEnumerable prompts)

garayx · 2025-11-03T14:48:18Z

src/main/java/net/ravendb/client/documents/AI/AiConversation.java

+    }
+
+    public <TAnswer> CompletableFuture<AiAnswer<TAnswer>> stream(
+            String streamPropertyPath,


we also have expression api in C#

public Task<AiAnswer<TAnswer>> StreamAsync<TAnswer>(Expression<Func<TAnswer, string>> streamPropertyPath, Func<string, Task> streamedChunksCallback, CancellationToken token = default)

src/main/java/net/ravendb/client/documents/commands/DeleteAiAgentCommand.java

garayx · 2025-11-03T15:10:31Z

src/main/java/net/ravendb/client/documents/commands/RunConversationCommand.java

+        }
+        if (this.streamPropertyPath != null) {
+            uriBuilder.append("&streamPropertyPath=").append(UrlUtils.escapeDataString(this.streamPropertyPath));
+            uriBuilder.append("&streaming=").append(UrlUtils.escapeDataString("true"));


why escape ?

garayx · 2025-11-03T15:19:43Z

src/main/java/net/ravendb/client/documents/operations/AI/AbstractAiSettings.java

+     *
+     * @param errors List to collect validation error messages.
+     */
+    public abstract void validate(List<String> errors);


should be validateFields, no?

garayx · 2025-11-03T16:15:16Z

src/main/java/net/ravendb/client/documents/operations/AI/OpenAiSettings.java

+                          String organizationId, String projectId,
+                          Integer dimensions, Double temperature) {


those are optional

done, made all possible combinations of ctors, because of clashing problem with ctors signatures.

garayx · 2025-11-03T16:15:49Z

src/main/java/net/ravendb/client/documents/operations/AI/VertexSettings.java

+    /**
+     * Represents the version of the Vertex AI API.
+     */
+    public enum VertexAIVersion {


move outside the class

garayx · 2025-11-03T16:16:14Z

src/main/java/net/ravendb/client/documents/operations/AI/VertexSettings.java

+        this.model = model;
+        this.googleCredentialsJson = googleCredentialsJson;
+        this.location = location;
+        this.aiVersion = aiVersion;


garayx · 2025-11-03T16:17:12Z

src/main/java/net/ravendb/client/documents/operations/AI/VertexSettings.java

+     */
+    public String getProjectId() {
+        try {
+            Pattern pattern = Pattern.compile("\"project_id\"\\s*:\\s*\"([^\"]+)\"");


what is this ? I dont see it in original code

https://github.com/ravendb/ravendb/blob/646797176f6285e71c0136e109c9723cc84cf446/src/Raven.Client/Documents/Operations/AI/VertexSettings.cs#L24

lets parse the json itself, without regex

garayx · 2025-11-03T16:19:32Z

...net/ravendb/client/documents/operations/connectionStrings/GetConnectionStringsOperation.java

+            Map<String, Object> raw = mapper.readValue(response, new TypeReference<Map<String, Object>>() {});
+            GetConnectionStringsResult result = mapper.readValue(response, GetConnectionStringsResult.class);
+
+            if (result.getRavenConnectionStrings() != null) {


why we need this? How it was working previously?

restored like previously.

src/main/java/net/ravendb/client/documents/AI/AiConversationCreationOptions.java

garayx · 2025-11-05T15:46:58Z

src/main/java/net/ravendb/client/documents/operations/AI/AiConnectionString.java

+        }
+    }
+
+    public int getQueryEmbeddingsMaxConcurrentBatches(int globalDefault) {


move this method to tests then and pass the connection string to it, somethign like this:

public int getQueryEmbeddingsMaxConcurrentBatches(AiConnectionString cs, int globalDefault) { AbstractAiSettings provider = cs.getActiveProviderInstance(); return provider != null && provider.getEmbeddingsMaxConcurrentBatches() != null ? provider.getEmbeddingsMaxConcurrentBatches() : globalDefault; }

Mayazt · 2025-11-09T12:23:32Z

src/main/java/net/ravendb/client/documents/AI/AiOperations.java

+     * Returns an AiOperations instance for a different database.
+     */
+    public AiOperations forDatabase(String databaseName) {
+        if (this.databaseName.equalsIgnoreCase(databaseName)) {


this.databaseName can be NULL , if t will be you will get an exception
please do a nullity check before comparing it

Mayazt · 2025-11-09T12:52:46Z

src/main/java/net/ravendb/client/documents/AI/TextPart.java

+public final class TextPart extends ContentPart {
+
+    @JsonProperty("text")
+    private String text;


maybe we should add the annotation @notblank(message = "text cannot be null or blank") if we want to make sure it won't be null or empty or just spaces

Mayazt · 2025-11-09T13:22:07Z

src/main/java/net/ravendb/client/documents/commands/AddOrUpdateAiAgentCommand.java

+import org.apache.hc.core5.http.ContentType;
+import java.io.IOException;
+
+public class AddOrUpdateAiAgentCommand extends RavenCommand<AiAgentConfigurationResult> implements IRaftCommand {


the class is public
in cs private sealed class AddOrUpdateAiAgentOperationCommand
it means it is not exposed to the client

Mayazt · 2025-11-09T13:33:01Z

src/main/java/net/ravendb/client/documents/commands/DeleteAiAgentCommand.java

+
+import java.io.IOException;
+
+public class DeleteAiAgentCommand extends RavenCommand<AiAgentConfigurationResult> {


same issue
in the cs code it is private.
it needs to be an innerclass of DeleteAiAgentOperation

Mayazt · 2025-11-09T13:45:25Z

src/main/java/net/ravendb/client/documents/commands/RunConversationCommand.java

+    private final DocumentConventions conventions;
+    private String raftId;
+
+    public RunConversationCommand(RunConversationOperation<TAnswer> parent, DocumentConventions conventions) {


same needs to be internal

Mayazt · 2025-11-09T14:02:35Z

src/main/java/net/ravendb/client/documents/operations/AI/AiConnectionString.java

+        return diffs.isEmpty() || (diffs.size() == 1 && diffs.contains(AiSettingsCompareDifferences.None));
+    }
+
+    public boolean usingEncryptedCommunicationChannel() {


in cs internal bool UsingEncryptedCommunicationChannel() it means that it is not exposed to someone that he is not developing on this project.
the best definition as I saw is without public or private

#123 (comment)

@garayx what should be our approach? making both methods internal and to expose accessibility inside tests package, or keeping it public?

Mayazt · 2025-11-09T14:03:19Z

src/main/java/net/ravendb/client/documents/operations/AI/AiConnectionString.java

+        }
+    }
+
+    public int getQueryEmbeddingsMaxConcurrentBatches(int globalDefault) {


same for this

#123 (comment)

@garayx what should be our approach? making both methods internal and to expose accessibility inside tests package, or keeping it public?

LielNagar added 3 commits October 27, 2025 14:09

RDBC-959: added AI agent feature- WIP

bd23b75

RDBC-959: sync with nodejs RDBC-944- WIP

db1aad7

RDBC-959: fixed cs type enum as RavenDB server, ignoring irrelevant j…

36b9414

…son data for tests

LielNagar force-pushed the RDBC-959 branch 2 times, most recently from 72ce05f to 902dd9f Compare October 27, 2025 13:13

LielNagar changed the title ~~RDBC-959 from base repo~~ RDBC-959: Add AI agent feature Oct 27, 2025

LielNagar force-pushed the RDBC-959 branch from 902dd9f to 98372e3 Compare October 28, 2025 09:26

RDBC-959: test enable by version annotation

cdd9ab9

LielNagar force-pushed the RDBC-959 branch from 98372e3 to cdd9ab9 Compare October 28, 2025 09:34

garayx requested changes Oct 30, 2025

View reviewed changes

LielNagar added 2 commits November 3, 2025 12:40

RDBC-959: change folders' structure, AI api naming, createAgent overload

f331779

RDBC-959: added real agent basic api test

ee65ff8

garayx requested changes Nov 3, 2025

View reviewed changes

LielNagar force-pushed the RDBC-959 branch from c19505a to 0e58a40 Compare November 5, 2025 15:10

garayx reviewed Nov 5, 2025

View reviewed changes

garayx approved these changes Nov 6, 2025

View reviewed changes

LielNagar force-pushed the RDBC-959 branch from 8f16e0c to 614bb41 Compare November 6, 2025 09:59

garayx requested a review from Mayazt November 6, 2025 10:41

RDBC-960: address PR comments

28fbf7f

LielNagar force-pushed the RDBC-959 branch from 614bb41 to 28fbf7f Compare November 6, 2025 12:12

Mayazt reviewed Nov 9, 2025

View reviewed changes

LielNagar added 2 commits November 10, 2025 10:53

RDBC-959: move commands internally into operation files

ad3fe10

RDBC-959: sync with 7.1.3 -> 7.1.4 diff related to AI

a99bbae

LielNagar force-pushed the RDBC-959 branch from 11e8b8e to a99bbae Compare November 10, 2025 12:45

		@@ -0,0 +1,180 @@
		package net.ravendb.client.test.client.documents.AI;

	public AiOperations getAiOperations(){
	public AiOperations AI(){

		@@ -0,0 +1,180 @@
		package net.ravendb.client.test.client.documents.AI;

		import net.ravendb.client.RemoteTestBase;

		@@ -0,0 +1,31 @@
		package net.ravendb.client.documents.operations.AI;

		@@ -0,0 +1,93 @@
		package net.ravendb.client.documents.operations.AI;

	AddOrUpdateAiAgentOperation createOp = new AddOrUpdateAiAgentOperation(agentConfiguration, null);
	AddOrUpdateAiAgentOperation createOp = new AddOrUpdateAiAgentOperation(agentConfiguration);

		String organizationId, String projectId,
		Integer dimensions, Double temperature) {


		import java.io.IOException;

		public class DeleteAiAgentCommand extends RavenCommand<AiAgentConfigurationResult> {

RDBC-959: Add AI agent feature #123

Are you sure you want to change the base?

RDBC-959: Add AI agent feature #123

Uh oh!

Conversation

LielNagar commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

LielNagar commented Oct 27, 2025 •

edited

Loading