Skip to content

JS Client: Add websocket support #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

JS Client: Add websocket support #101

wants to merge 6 commits into from

Conversation

@turtleDev
Copy link
Contributor

@turtleDev turtleDev commented Oct 7, 2024 •
edited
Loading

  • Adds support for Websocket protocol in Javascript Client.
  • User can pass in options.protocol as ws to request websocket protocol. (defaults to rest)
  • Client is now a subclass of EventEmitter. When ws protocol is enabled, the client emits an ack event for every server response.
  • Updated user documentation to add details about Websocket support

@coveralls
Copy link

coveralls commented Oct 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11218539072

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.269%
Totals Coverage Status
Change from base Build 10996506167: 0.0%
Covered Lines: 1896
Relevant Lines: 2333
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mustafiz04 Mustafiz04 Mustafiz04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@turtleDev @coveralls @Mustafiz04