Skip to content

Conversation

whitesscott
Copy link
Contributor

@whitesscott whitesscott commented Oct 10, 2025

  • Added install_jtop_torun_without_sudo.sh for user-level jtop installation
  • Updated README.md with Option 4 instructions and link to new guide
  • Added docs/nosudo.rst explaining how the script works and why to use it

Summary by Sourcery

Enable user-level installation and execution of jtop without requiring sudo by providing a dedicated helper script, updating the README with a new install option, and adding comprehensive documentation

New Features:

  • Add a helper script to install and run jtop without sudo using pipx
  • Introduce Option 4 in the README to guide users to the no-sudo installation flow

Documentation:

  • Add a detailed docs/nosudo.rst guide explaining the no-sudo installation process and rationale

- Added install_jtop_torun_without_sudo.sh for user-level jtop installation
- Updated README.md with Option 4 instructions and link to new guide
- Added docs/nosudo.rst explaining how the script works and why to use it
Copy link
Contributor

sourcery-ai bot commented Oct 10, 2025

Reviewer's Guide

This PR introduces a user-level, no-sudo installation flow for jtop by adding a helper script, updating the README with Option 4 instructions, and including detailed docs on how and why the script works.

File-Level Changes

Change Details Files
Introduce a non-root jtop install helper script
  • Guard against running as root; prompt for sudo credential ahead of time
  • Check for pip3 and pipx, installing missing packages via apt
  • Use pipx to install jetson_stats from GitHub
  • Create and configure a systemd unit if absent
  • Enable and start the jtop service without requiring sudo at runtime
install_jtop_torun_without_sudo.sh
Update README with Option 4 no-sudo install instructions
  • Add ‘Ubuntu 24.04 run jtop without sudo’ section
  • Describe sudo -v preflight, script download, chmod, and execution steps
  • Link to the full nosudo guide in docs/nosudo.rst
README.md
Add nosudo.rst documentation
  • Explain how the helper script works
  • Describe benefits of user-level installation without sudo
docs/nosudo.rst

Possibly linked issues

  • #N/A: The PR adds a script and documentation to enable non-root users to run jtop without sudo, directly resolving the permission issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `README.md:73` </location>
<code_context>
+First run "sudo -v"
+    -v, --validate does not run any command, but does allow the use of sudo in the bash script.
+Then "download install_jtop_torun_without_sudo.sh"
+Make it executible:
+chmod +x install_jtop_torun_without_sudo.sh
+Then run it:
</code_context>

<issue_to_address>
**issue (typo):** Typo: 'executible' should be 'executable'.

Please update the spelling to 'executable'.

```suggestion
Make it executable:
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

whitesscott and others added 2 commits October 9, 2025 17:13
spellcheck one word

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants