-
-
Notifications
You must be signed in to change notification settings - Fork 299
docs: add no-sudo jtop install guide and helper script #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Added install_jtop_torun_without_sudo.sh for user-level jtop installation - Updated README.md with Option 4 instructions and link to new guide - Added docs/nosudo.rst explaining how the script works and why to use it
Reviewer's GuideThis PR introduces a user-level, no-sudo installation flow for jtop by adding a helper script, updating the README with Option 4 instructions, and including detailed docs on how and why the script works. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `README.md:73` </location>
<code_context>
+First run "sudo -v"
+ -v, --validate does not run any command, but does allow the use of sudo in the bash script.
+Then "download install_jtop_torun_without_sudo.sh"
+Make it executible:
+chmod +x install_jtop_torun_without_sudo.sh
+Then run it:
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'executible' should be 'executable'.
Please update the spelling to 'executable'.
```suggestion
Make it executable:
```
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
spellcheck one word Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Summary by Sourcery
Enable user-level installation and execution of jtop without requiring sudo by providing a dedicated helper script, updating the README with a new install option, and adding comprehensive documentation
New Features:
Documentation: