VPLAY-11433 : Enhancement Request: Utilize Existing Player Source Field in PCTune_split to Indicate VIPA vs Non-VIPA Playback#1000
Merged
shripadbpersonal merged 3 commits intosupport/2.9.0_8.3_vipafrom Feb 15, 2026
Conversation
…ld in PCTune_split to Indicate VIPA vs Non-VIPA Playback Reason for Change : To better collect and analyze tune metrics, use the existing player source string field to differentiate VIPA Playback Test Procedure: Tune to linear/VOD content , verify Tune log Priority : p1 Risks: Low Signed-off-by: haripriya_molakalapalli <haripriya_molakalapalli@comcast.com>
…ld in PCTune_split to Indicate VIPA vs Non-VIPA Playback Reason for Change : To better collect and analyze tune metrics, use the existing player source string field to differentiate VIPA Playback Test Procedure: Tune to linear/VOD content , verify Tune log Priority : p1 Risks: Low Signed-off-by: haripriya_molakalapalli <haripriya_molakalapalli@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates AAMP tune-end profiling output to distinguish VIPA (Firebolt SDK) playback from non-VIPA playback in the emitted IP_AAMP_TUNETIME metrics prefix.
Changes:
- Append
"_VIPA"toappNameinProfileEventAAMP::TuneEnd()wheneAAMPConfig_UseFireboltSDKis enabled. - Increase
tuneTimeStrPrefixbuffer size from 64 to 128 bytes to accommodate the longer prefix.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
molakalapalliharipriya
changed the title
Comment on lines
+300
to
304
| if (gpGlobalConfig && gpGlobalConfig->IsConfigSet(eAAMPConfig_UseFireboltSDK)) | ||
| { | ||
| appName += "_VIPA"; | ||
| } | ||
| snprintf(tuneTimeStrPrefix, sizeof(tuneTimeStrPrefix), "%s PLAYER[%d] APP: %s IP_AAMP_TUNETIME", playerActiveMode.c_str(),playerId,appName.c_str()); |
There was a problem hiding this comment.
Appending "_VIPA" directly to appName changes not only the log prefix but also the app field in the TuneMetrics JSON (and the trailing CSV AppName field) emitted later in this function. If the VIPA marker is intended only for the pre/prefix used by downstream log parsers, derive a separate labeled string for the prefix instead of mutating appName.
Suggested change
| if (gpGlobalConfig && gpGlobalConfig->IsConfigSet(eAAMPConfig_UseFireboltSDK)) | |
| { | |
| appName += "_VIPA"; | |
| } | |
| snprintf(tuneTimeStrPrefix, sizeof(tuneTimeStrPrefix), "%s PLAYER[%d] APP: %s IP_AAMP_TUNETIME", playerActiveMode.c_str(),playerId,appName.c_str()); | |
| std::string appNameForPrefix = appName; | |
| if (gpGlobalConfig && gpGlobalConfig->IsConfigSet(eAAMPConfig_UseFireboltSDK)) | |
| { | |
| appNameForPrefix += "_VIPA"; | |
| } | |
| snprintf(tuneTimeStrPrefix, sizeof(tuneTimeStrPrefix), "%s PLAYER[%d] APP: %s IP_AAMP_TUNETIME", playerActiveMode.c_str(),playerId,appNameForPrefix.c_str()); |
shripadbpersonal
merged commit 1a73c0d
into
support/2.9.0_8.3_vipa
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.