VPLAY-12634 [Rogers] [VIPA] CEA-708 CC track selection failure on Multiview by anjali-syna · Pull Request #1010 · rdkcentral/aamp

anjali-syna · 2026-02-11T03:36:13Z

Adding changes to solve the problem of CEA-708 Closed Caption track selection failing on Multiview stream.

…ails on Multiview stream

Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>

… feature/VPLAY-12634

Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>

Copilot

Pull request overview

This pull request fixes a CEA-708 closed caption track selection issue on multiview streams by ensuring that the track format (608/708) is properly cached and used when adding format-specific prefixes to numeric track identifiers in the Rialto closed caption manager.

Changes:

Added caching of CCFormat in PlayerCCManagerBase to preserve format information across operations
Modified PlayerRialtoCCManager::SetTrack to add appropriate prefixes ("CC" for 608, "SERVICE" for 708) to numeric-only track identifiers
Updated RestoreCC and ResetState methods to properly handle the cached track format

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
middleware/closedcaptions/rialto/PlayerRialtoCCManager.cpp	Added logic to detect numeric track IDs and prepend format-specific prefixes based on cached format; includes `<cctype>` for `std::isdigit()`
middleware/closedcaptions/PlayerCCManager.h	Added `mTrackFormat` member variable to cache the CC format alongside the track string
middleware/closedcaptions/PlayerCCManager.cpp	Updated `SetTrack`, `RestoreCC`, and `ResetState` to cache and use `mTrackFormat` for maintaining format consistency

middleware/closedcaptions/rialto/PlayerRialtoCCManager.cpp

Copilot · 2026-02-17T13:42:23Z

middleware/closedcaptions/rialto/PlayerRialtoCCManager.cpp

+		// We expect 'track' to have an alphabetic prefix. If it does not,
+		// add one based on 'format'.
+		std::string textTrackIdentifier;
+		if (std::isdigit(track[0]))
+		{
+			if (eCLOSEDCAPTION_FORMAT_608 == format)
+			{
+				textTrackIdentifier = "CC";
+			}
+			else if (eCLOSEDCAPTION_FORMAT_708 == format)
+			{
+				textTrackIdentifier = "SERVICE";
+			}
+		}
+		textTrackIdentifier += track;


The logic only adds a prefix when track[0] is a digit, but it concatenates track to textTrackIdentifier unconditionally. When the track already has an alphabetic prefix (e.g., "CC1" or "SERVICE1"), textTrackIdentifier will be empty from the if-block, and the concatenation on line 136 will just use the original track string. However, if the track is something like "1" and format is neither 608 nor 708 (e.g., DEFAULT), textTrackIdentifier will remain empty and will be set to just "1", which may not be the intended behavior. Consider adding an else branch to handle the case where format is DEFAULT and track starts with a digit.

This is intentional. If the track string does not have an alphabetic prefix AND we aren't told how to treat it in order to add the correct alphabetic prefix, the original string is always passed through - the code receiving it may still know what to do with it.

middleware/closedcaptions/rialto/PlayerRialtoCCManager.cpp

dnfaulkner

Looks OK to me

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-18T17:42:32Z

middleware/closedcaptions/PlayerCCManager.cpp

 		trackId = "CC1";
+		trackFormat = eCLOSEDCAPTION_FORMAT_DEFAULT;
 	}

-	SetTrack(trackId);
+	SetTrack(trackId, trackFormat);


RestoreCC() now preserves and forwards the previously selected CCFormat via trackFormat when re-selecting the track. This changes behavior for numeric instream IDs (e.g., "1") that rely on the format to be interpreted correctly, but there doesn’t appear to be a unit test asserting that the restored track selection passes the same format that was originally set. Add a focused unit test covering restore behavior with a numeric track id + 608/708 format to prevent regressions.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

…1010) VPLAY-12634 [VIPA] CEA-708 Closed Captions track selection fails on Multiview stream Reason for Change: This pull request fixes a CEA-708 closed caption track selection issue on multiview streams by ensuring that the track format (608/708) is properly cached and used when adding format-specific prefixes to numeric track identifiers in the Rialto closed caption manager. Test Guidance: refer ticket Risk: low --------- Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com> Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hthakkar-synamedia <115170760+hthakkar-synamedia@users.noreply.github.com>

…1010) (#1061) VPLAY-12634 [VIPA] CEA-708 Closed Captions track selection fails on Multiview stream Reason for Change: This pull request fixes a CEA-708 closed caption track selection issue on multiview streams by ensuring that the track format (608/708) is properly cached and used when adding format-specific prefixes to numeric track identifiers in the Rialto closed caption manager. Test Guidance: refer ticket Risk: low --------- Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com> Co-authored-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com> Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hthakkar-synamedia <115170760+hthakkar-synamedia@users.noreply.github.com>

…1010) VPLAY-12634 [VIPA] CEA-708 Closed Captions track selection fails on Multiview stream Reason for Change: This pull request fixes a CEA-708 closed caption track selection issue on multiview streams by ensuring that the track format (608/708) is properly cached and used when adding format-specific prefixes to numeric track identifiers in the Rialto closed caption manager. Test Guidance: refer ticket Risk: low --------- Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com> Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hthakkar-synamedia <115170760+hthakkar-synamedia@users.noreply.github.com>

anjali-syna added 6 commits February 11, 2026 09:03

VPLAY-12634 [Rogers] [VIPA] CEA-708 Closed Captions track selection f…

fff6c9c

…ails on Multiview stream

Trying a change to test VPLAY-12637

2c46e1b

Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>

Merge branch 'dev_sprint_25_2' into feature/VPLAY-12634

48e0b87

Removing VPLAY-12637 changes

107f6a9

Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>

Merge branch 'feature/VPLAY-12634' of github.com:rdkcentral/aamp into…

9ae8098

… feature/VPLAY-12634

Code is modified

00f8376

Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>

anjali-syna marked this pull request as ready for review February 17, 2026 13:38

anjali-syna requested a review from a team as a code owner February 17, 2026 13:38

anjali-syna requested review from Copilot and dnfaulkner February 17, 2026 13:38

Copilot started reviewing on behalf of anjali-syna February 17, 2026 13:38 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

dnfaulkner reviewed Feb 17, 2026

View reviewed changes

Update middleware/closedcaptions/rialto/PlayerRialtoCCManager.cpp

fc9842c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 18, 2026 17:37

Copilot started reviewing on behalf of pstroffolino February 18, 2026 17:38 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Apply suggestion from @Copilot

d902db1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 18, 2026 18:28

Copilot started reviewing on behalf of hthakkar-synamedia February 18, 2026 18:29 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Merge branch 'dev_sprint_25_2' into feature/VPLAY-12634

235d5ab

pstroffolino merged commit b065105 into dev_sprint_25_2 Feb 18, 2026
7 of 8 checks passed

pstroffolino deleted the feature/VPLAY-12634 branch February 18, 2026 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VPLAY-12634 [Rogers] [VIPA] CEA-708 CC track selection failure on Multiview#1010

VPLAY-12634 [Rogers] [VIPA] CEA-708 CC track selection failure on Multiview#1010
pstroffolino merged 9 commits intodev_sprint_25_2from
feature/VPLAY-12634

anjali-syna commented Feb 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

kd-syna Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

dnfaulkner left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

anjali-syna commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

kd-syna Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dnfaulkner left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anjali-syna commented Feb 11, 2026 •

edited

Loading