-
Notifications
You must be signed in to change notification settings - Fork 9
VPLAY-11339: [DOC] eAAMPConfig_NativeCCRendering and setTextStyleOptions #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
80bbaee
ae7af5e
82ac306
c6b8e9e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2811,7 +2811,27 @@ std::string PlayerInstanceAAMP::GetAppName() | |||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| /** | ||||||||||||||||||||||
| * @brief Enable/disable the native CC rendering feature | ||||||||||||||||||||||
| * @brief Enable or disable AAMP-managed CC rendering. | ||||||||||||||||||||||
| * | ||||||||||||||||||||||
| * When enable is true, AAMP takes ownership of the CC rendering lifecycle | ||||||||||||||||||||||
| * via PlayerCCManager: initialization on first frame, trickplay muting, | ||||||||||||||||||||||
| * parental control gating (SERVICE_PIN_LOCKED events), CEA-608/708 track | ||||||||||||||||||||||
| * selection, and session teardown on stop. | ||||||||||||||||||||||
|
Comment on lines
+2817
to
+2819
|
||||||||||||||||||||||
| * via PlayerCCManager: initialization on first frame, trickplay muting, | |
| * parental control gating (SERVICE_PIN_LOCKED events), CEA-608/708 track | |
| * selection, and session teardown on stop. | |
| * via PlayerCCManager: integrating CC with playback on first-frame | |
| * presentation, applying trickplay muting, enforcing parental control | |
| * gating (SERVICE_PIN_LOCKED events), driving CEA-608/708 track | |
| * selection, and performing CC-specific session teardown on stop. | |
| * Note that underlying CC components (e.g. PlayerCCManager::Init) are | |
| * initialised unconditionally; this flag controls AAMP's additional | |
| * lifecycle and policy integration, not whether CC is initialised. |
Copilot
AI
Feb 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling is inconsistent with the rest of the codebase’s American English usage: “behaviour”/“initialised” should be “behavior”/“initialized”.
| * behaviour or policy decisions (e.g. trickplay muting, parental-control | |
| * integration, or CC-specific teardown). Internal components such as | |
| * PlayerCCManager may still be initialised but internally it will be | |
| * behavior or policy decisions (e.g. trickplay muting, parental-control | |
| * integration, or CC-specific teardown). Internal components such as | |
| * PlayerCCManager may still be initialized but internally it will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config’s doc says it controls whether AAMP “manages CC visibility/styles directly”, but the runtime gating for eAAMPConfig_NativeCCRendering is primarily around automatic lifecycle/policy integration (e.g., SetTrickplayStatus, SetParentalControlStatus, Release on stop, and a limited CEAPreferred override). Style/status/track APIs still call into PlayerCCManager regardless of this flag. Please update the comment to reflect the actual behaviors gated by the config so the header documentation matches runtime behavior.