Enhancement Request: Utilize Existing Player Source Field in PCTune_split to Indicate VIPA vs Non-VIPA Playback#999
Open
molakalapalliharipriya wants to merge 190 commits intodev_sprint_25_2from
Open
Conversation
Reason for change: 2506 Federated Merge 2.6.1 Test Procedure: Build and Verify Risks: Low Priority: P2
Revert "VPLAY-9299:Address 200ms tune delay when using enableMediaProcessor as true."
…dingDiscontinuity Reason for Change: Do not delete stream abstraction instance if pending discontinuity process is in progress Test Procedure: Please see the ticket Risks: Low priority:P0 Change-Id: I11a23f2d483ed3fcaa3b3b517ed7264f93e78f46 Signed-off-by: Gnanesha <Gnanesha_Thimmegowda@comcast.com>
…channels (#135) Reason for change: Changed DrmSessionManager::createDrmSession() to check for cachedKeyIDs before updating it's failed status during failure. This will avoid crash due to race condition caused by stop() Test Procedure: Refer Jira Risks: Low Priority: P1 Signed-off-by: Sivasubramanian <sivasubramanian.patchaiperumal@ltts.com> Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com>
… after rewind operation on linear channels / SLE contents Revert "VPLAY-9393 HLS bitrate remains low post stream freeze" Reason for Change: Revert "VPLAY-9393 HLS bitrate remains low post stream freeze" which is causing the issue Test Procedure: Please see the ticket Risks: Low priority:P1 This reverts commit 633f0b67c48230438cfe3764bf8d490d379d138e.
Reason for change: EPG currently behaves badly when state is set to eSTATE_RELEASED instead of eSTATE_IDLE after stopping Test Procedure: Tune to any linear channels, Try changing the channels and see tune was successful with out any blue screen Risks: Medium Signed-off-by: haripriya_molakalapalli <haripriya_molakalapalli@comcast.com>
VPLAY-9931 : AAMP Player State Simplification (deprecate RELEASED, STOPPED)
Merge branch 'release/2.4.4'
RDKEMW-5467
RDKEMW-5467 : Set PlayerState to IDLE during stop
Reason for Change: Disable AAMP TSB if FOG is used Test Procedure: Please see the ticket Risks: Low Signed-off-by: Jose Fagundez <jfagunde@synamedia.com> Add manifest parameter to IsFogUrl() Add L1 tests
…XiOne-Foxtel Reason for change: Updating Curldownloader instances upon calling UpdateMaxDrmSession Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: I2b4c22d9a381f792eb08dfe8a49eecabe6f374d6 Signed-off-by: Deepikasri N <Deepikasri_N@Comcast.Com
…back in XiOne-Foxtel This reverts commit 5efc21c.
…XiOne-Foxtel Reason for change: Updating Curldownloader instances upon calling UpdateMaxDrmSession Test Procedure: Refer Ticket Risks: Low Priority: P1 Change-Id: I2b4c22d9a381f792eb08dfe8a49eecabe6f374d6 Signed-off-by: Deepikasri N <Deepikasri_N@Comcast.Com VPLAY-9906 [Foxtel][AAMP]Crash is observed during 4K VOD playback in XiOne-Foxtel Reason for change: Addressed review comments. Test Procedure: Refer Ticket Risks: Low
…506_develop RDK-57972/RDKEMW-5568 AAMP Federated Release for Sprint 2506 - Tag 2.6.0
Reason for change: Clear duration value in mdhd mp4 box in init fragment for live streams. This ensures qtdemux will sent a segment event prior to playback start Test Procedure: Linear channel playback should work as expected Risks: Low Signed-off-by: Vinish100 <vinish.balan@gmail.com>
VPLAY-9946: Playback failed in for certain live channels
Merge branch 'release/2.6.0'
RDKEMW-5568
Reason for change: Fix log flooding by changing the log levels Test Procedure: Look out for log flooding of mentioned logs during linear playback Risks: None Signed-off-by: Vinish100 <vinish.balan@gmail.com>
VPLAY-10093: Log flooding with Linear SLD channels
Merge branch 'release/2.6.1'
RDKEMW-5568 VPLAY-10093
Reason for change: Test Procedure: Priority: P2 Risks:Low
Reason for change: Added expect call to failing tests Test Procedure: L1 tests should pass Priority: P2 Risks:Low Signed-off-by: asasik397 <Abhijith_Sasikumar@comcast.com>
…eature/VPLAY-9946_l1
Revert "VPLAY-9946: L1 errors fixes "
VPLAY-11269: Fix mem leak in AampProfiler (#541) Reason for change: Release the memory allocated to convert json to string. Also handle mLldLowBuffObject properly Test Procedure: Make sure no mem leaks observed on tune tests. Refer ticket for some cases Risks: Low Priority: P0 Signed-off-by: Vinish100 <vinish.balan@gmail.com>
…rmal rate 1x playback after seeking or trick-playing into an ad break (#509) VPLAY-11042: [VIPA][AAMP TSB] No ad progress reports when resuming normal rate 1x playback after seeking or trick-playing into an ad break (#509) Reason for Change: * If seek (or resume from trickplay) within ad advert reservation period, raise the RESERVATION_START event * Suppress PLACEMENT_END, and RESERVATION_END if not had the START events. * Coverity changes * Change to the sorting logic for ad events at the same position * Correction to the AD event sorting * Coverity fixes Test Guidance: refer ticket Risk: Low --------- Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcas.t.com>
VPLAY-11244 : [VIPA] [Release] v 1.3.0
VPLAY-11352: Crash Observed while Playback of linear LLD HD/UHD (#563) Reason for change: avoid double-free - mLldLowBuffObject is a child of telemetryParam, so it's automatically deleted. Test Procedure: As mentioned in ticket Risks: None Signed-off-by: Vinish100 <vinish.balan@gmail.com>
…ly while playing HD/UHD linear and VOD VPLAY-11457 [VIPA][LLAMA G1/G2/IT]: Technical Fault issue seen randomly while playing HD/UHD linear and VOD Reason for Change: Firebolt DRM request was sometimes (barely) timing out and failing. Changed timeout from 3s to more generous 5s. Test Guidance: monitor for reduced occurrence of VIPA tune failures Risk: Low Co-authored-by: nrames759 <Naren_Ramesh@comcast.com>
VPLAY-11397 : [VIPA] [Release] v 1.3.1
Reason for change:Fix for js logging Test Procedure:Refer ticket Priority: P2 Risks:Low Signed-off-by: Abhi-jith-S <abhijithssa7@gmail.com>
VPLAY-11251 : Fix for js logging
VPLAY-11231 Resolving Watermarking Event handling in support branch
…591) VPLAY-11435 Switch to play when the beginning of the TSB is reached (#591) Reason for Change: * Switch to play when the beginning of the TSB is reached * Handle BoS even if rate is not < 0 * Send BoS notification with position=0 * Revert to setting position=start when reaching BoS * Only handle the BoS if rate is negative * Address review comments: rename to PlayFromTsbStart(), add L1 test... * Check the rate before calling PlayFromTsbStart() * Replace verbose MIL with TRACE * Rename ReportProgress() to MonitorProgress() and extend the function comments Test Guidance: refer ticket Risk: Low --------- Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com>
VPLAY-11583 Rename StreamAbstractionAAMP_MPD::rate to mPlayRate Reason for Change: Distinguish this variable rate from other variables Test Procedure: AAMP and L1 should build successfuly Risk: Low
…ickplay (#640) VPLAY-11328 - [Linear]Progress Bar jumping to the End/beginning while performing Trick Play Reason for change: Progress Bar Point is jumping to the End/beginning while performing Trick Play/Seek in linear services. While analysing the pts value of the segments, it is noticed that the restamped pts value of some of the segments in the main content is a very high value compared to the previous segment. This is happening because a wrong timescale is used for pts re calculation. RecalculatePTS function is using the timescale value saved in PrivateInstanceAAMP. When the downloads progresses from content to ad the timescale of the segment can change. When this happens, if the pay rate is not normal play rate, the new timescale is not set to PrivateInstanceAAMP and thus causing the issue. Changes: * CacheFragment function is modified to set the timescale to PrivateInstanceAAMP irrespective of the play rate. Test Procedure: Refer JIRA ticket Risks: low * Adding new L1 test Signed-off-by: anjali-syna <206662904+anjali-syna@users.noreply.github.com>
…de (#650) VPLAY-11545: OSX runtime failure running AampTSBSessionManager in Xcode Reason for Change: Restructured sort code, to improve structure and readability and remove strict-weak ordering exception Test Guidance: l1 AampTsbSessionManager passing both with run.sh and when run in xcode l2 test 5003 passing Risk: Low Signed-off-by: anshephe <115161257+anshephe@users.noreply.github.com>
VPLAY-11677 [VIPA] Release 1.3.2
…ssion(), which was missed during the DRM refactoring (#619) VPLAY-11530 Increase in tune failures Reason for Change : Reintroduced the condition check before calling clear() in clearDrmSession. This was lost during DRM refactoring.
VPLAY-11677 : Release 1.3.2
VPLAY-11677:Create aamp artifacts for Vipa version 1.3.2
…AMP to crash VPLAY-11880:The manifest download keeps failing, eventually causing the AAMP to crash. (#718) * Split AampCurlDownloader::Release() to fix thread-safe resource cleanup Separated the Release() function into two parts to ensure thread-safe cleanup of curl headers: 1. Release() - Disables the downloader by setting mDownloadActive flag, allowing download threads to exit gracefully 2. ReleaseHeaders() - Cleans up curl headers and resets timing variables after threads have been joined This prevents race conditions where headers could be freed while download threads are still active and potentially accessing them. * Updated function name to better describe its purpose of initializing CURL header resources * Added L1 test case --------- Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com> Co-authored-by: vkadun208_comcast <vinod_kadungoth2@comcast.com>
VPLAY-11880:The manifest download keeps failing, eventually causing A…
…leanup parameter to prevent Deep Sleep playback failures (#704) * Update AAMP-UVE-API.md * VPLAY-11809 : Enhance UveAAMP stop() API with DRM handle cleanup parameter to prevent Deep Sleep playback failures Reason for change: Linear and VOD playback fails after devices come out of Deep Sleep state due to stale DRM handles that are not properly released before entering Deep Sleep mode. The current stop() implementation does not provide a mechanism to force DRM handle cleanup, leading to tune failures with stale DRM sessions after device wake-up. Changes done: - Enhanced PlayerInstanceAAMP::Stop() API with optional forceCleanup parameter (default false) - Added DRM session cleanup logic using licenseManager->clearDrmSession(forceClearSession) and clearFailedKeyIds() - Updated JavaScript bindings to support both single parameter stop(forceCleanup) and two parameter stop(sendStateChangeEvent, forceCleanup) forms - Modified jsmediaplayer.cpp to handle argument parsing for backward compatibility - Updated UVE API documentation with usage examples for Deep Sleep scenarios - Enhanced mock files and test infrastructure to maintain compatibility - Added comprehensive logging for debugging Deep Sleep DRM cleanup operations This allows applications to call player.stop(true) before Deep Sleep to proactively clean up DRM resources and prevent playback failures after wake-up. Test Procedure: Priority: P2 Risks:Low * Update AAMP-UVE-API.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update AAMP-UVE-API.md * Update AAMP-UVE-API.md * Call Stop with forceCleanup for clearing DRM session when setRateis invoked with magic number * Follow up commit - Cleanup triggered: Stop() and Destroy() called back-to-back; Stop() invoked without arguments and as part of Destroy/Release internal call to stop releases all the DRM resources * Follow up commit - Cleanup triggered: Stop() and Destroy() called back-to-back; Stop() invoked without arguments and as part of Destroy/Release internal call to stop releases all the DRM resources --------- Co-authored-by: shripadbpersonal <105402691+shripadbpersonal@users.noreply.github.com> Co-authored-by: shripad bankar <Shripad_Bankar@cable.comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ld in PCTune_split to Indicate VIPA vs Non-VIPA Playback Reason for Change : To better collect and analyze tune metrics, use the existing player source string field to differentiate VIPA Playback Test Procedure: Tune to linear/VOD content , verify Tune log Priority : p1 Risks: Low Signed-off-by: haripriya_molakalapalli <haripriya_molakalapalli@comcast.com>
…ld in PCTune_split to Indicate VIPA vs Non-VIPA Playback Reason for Change : To better collect and analyze tune metrics, use the existing player source string field to differentiate VIPA Playback Test Procedure: Tune to linear/VOD content , verify Tune log Priority : p1 Risks: Low Signed-off-by: haripriya_molakalapalli <haripriya_molakalapalli@comcast.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.