rbus: fixup reverse null check in rtMessage_Retain_test1#418
Open
svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
Open
rbus: fixup reverse null check in rtMessage_Retain_test1#418svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
svc-rdkeportal01 wants to merge 1 commit intodevelopfrom
Conversation
Coverity issue ID: 139 (REVERSE_INULL) Fix generated by RDKDevPilot AI Bot following pattern from PR #382 The code was checking if msg is NULL after already dereferencing it in rtMessage_Retain(msg). This is a logic error - if msg was NULL, it would crash before reaching the NULL check. Fix: Removed redundant NULL check since rtMessage_Create() guarantees msg is non-NULL or the test would fail earlier. Co-authored-by: rdkdevpilot <bot@rdkcentral.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix REVERSE_INULL in rtMessage_Retain_test1
Issues Fixed
unittests/rbus_unit_test_server.cppat line 1320Root Cause
The code was checking if
msgis NULL after already dereferencing it inrtMessage_Retain(msg). This is a logic error - ifmsgwas NULL, the code would crash at line 1317 before reaching the NULL check at line 1320.Changes Made
Removed redundant NULL check:
Before:
After:
Why This Fix is Correct
rtMessage_Create()guaranteesmsgis non-NULLmsgwas NULL, the test would fail atEXPECT_EQ(err, RT_OK)rtMessage_Release()is intentional (testing double release behavior)