Fix expired not_on_or_after dates in keyctrl tests (MTK-1774)#72
Closed
seanjin99 wants to merge 1 commit intordkcentral:mainfrom
Closed
Fix expired not_on_or_after dates in keyctrl tests (MTK-1774)#72seanjin99 wants to merge 1 commit intordkcentral:mainfrom
seanjin99 wants to merge 1 commit intordkcentral:mainfrom
Conversation
Replace hardcoded not_on_or_after dates with a runtime-computed date (now + 10 years) so tests never expire. The previous hardcoded date of 2025-12-09 had already expired, causing testKeyCtrlUnwrapWithKeyUsage and related tests to fail with 'rights_allowed_time' errors.
seanjin99
force-pushed
the
fix/MTK-1774-expired-test-dates
branch
from
d56442b to
0d172e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded not_on_or_after date '2025-12-09' in keyctrl.cpp test cases has expired, causing testKeyCtrlUnwrapWithKeyUsage and related tests to fail with 'Current time is outside of key validity window' from the TA's rights_allowed_time check.
Updated all 7 occurrences from 2025-12-09 to 2035-12-09 to extend validity for another 10 years.