RDKEMW-10725:gstreamer-cleanup when /opt/cdl_flashed_file_name is missing

lib/rdk/gstreamer-cleanup.sh

@@ -0,0 +1,43 @@
+#!/bin/bash
+
+# This script checks if the GStreamer registry should be cleared based on
+# firmware flash status and cleans it if necessary.
+
+# Initialize variables safely
+CDLFILE=""
+PREV_CDLFILE=""
+CUR_IMAGE=""
+
+if [[ -f /opt/cdl_flashed_file_name ]]; then
+    CDLFILE=$(cat /opt/cdl_flashed_file_name)
+fi
+if [[ -f /opt/previous_flashed_file_name ]]; then
+    PREV_CDLFILE=$(cat /opt/previous_flashed_file_name)
+fi
+if [[ -f /version.txt ]]; then
+    CUR_IMAGE=$(grep "^imagename:" /version.txt | cut -d":" -f2)
+fi
+
+# Print the variables for debugging - can be removed once the logic is stable
+echo "DEBUG: CDLFILE=[${CDLFILE}]"
+echo "DEBUG: PREV_CDLFILE=[${PREV_CDLFILE}]"
+echo "DEBUG: CUR_IMAGE=[${CUR_IMAGE}]"
+
+# Check all cleanup conditions in a single if statement using bash syntax
+if [[ ! -f /opt/previous_flashed_file_name || \
+      ( ! -f /opt/cdl_flashed_file_name && "${PREV_CDLFILE}" != *"${CUR_IMAGE}"* ) || \
+      ( -f /opt/cdl_flashed_file_name && "${CDLFILE}" != *"${PREV_CDLFILE}"* ) ]]; then
+
+    echo "Removing gstreamer registry on bootup after CDL"
+    rm -rf /opt/.gstreamer
+    GST_REGISTRY_UPDATE=yes gst-inspect-1.0 >/dev/null 2>&1
+
+elif [[ ! -f /opt/.gstreamer/registry.bin ]]; then
+    # Fallback: Clean if registry file is missing anyway
+    echo "Gstreamer registry empty"
+    rm -rf /opt/.gstreamer
+    GST_REGISTRY_UPDATE=yes gst-inspect-1.0 >/dev/null 2>&1
+else
+    echo "gstreamer registry is not removed, previous reboot is not due to CDL"
+fi
+

systemd_units/gstreamer-cleanup.service

@@ -26,12 +26,9 @@ Before=wpeframework.service
 [Service]
 Type=oneshot
 RemainAfterExit=Yes
-Environment="CDLFILE=$(cat /opt/cdl_flashed_file_name)"
-Environment="PREV_CDLFILE=$(cat /opt/previous_flashed_file_name)"
-Environment="GST_REGISTRY=/opt/.gstreamer/registry.bin"
-ExecStartPre=/bin/sh -c 'if [ -f /lib/rdk/logMilestone.sh ];then sh /lib/rdk/logMilestone.sh "GST_CLEANUP_START"; fi;'
-ExecStart=-/bin/sh -c 'if [[ ! -f /opt/previous_flashed_file_name || ! -f /opt/cdl_flashed_file_name || ${CDLFILE} != *"${PREV_CDLFILE}"* ]]; then echo "Removing gstreamer registry on bootup after CDL"; rm -rf /opt/.gstreamer;GST_REGISTRY_UPDATE=yes gst-inspect-1.0 >/dev/null 2>&1; elif [ ! -f /opt/.gstreamer/registry.bin ]; then echo "Gstreamer registry empty"; rm -rf /opt/.gstreamer; GST_REGISTRY_UPDATE=yes gst-inspect-1.0 >/dev/null 2>&1; else echo "gstreamer registry is not removed, previous reboot is not due to CDL"; fi'
-ExecStartPost=/bin/sh -c 'if [ -f /lib/rdk/logMilestone.sh ];then sh /lib/rdk/logMilestone.sh "GST_CLEANUP_COMPLETE"; fi;'
+ExecStartPre=/bin/bash -c 'if [ -f /lib/rdk/logMilestone.sh ];then sh /lib/rdk/logMilestone.sh "GST_CLEANUP_START"; fi;'
+ExecStart=-/lib/rdk/gstreamer-cleanup.sh
+ExecStartPost=/bin/bash -c 'if [ -f /lib/rdk/logMilestone.sh ];then sh /lib/rdk/logMilestone.sh "GST_CLEANUP_COMPLETE"; fi;'
 ExecStop=/bin/sh -c 'FW_UPDATE_STATE=$(cat /opt/fwdnldstatus.txt | grep FwUpdateState | cut -d "|" -f2); echo "FW_UPDATE_STATE: $FW_UPDATE_STATE"; if [ "$FW_UPDATE_STATE" == "Preparing to reboot" ]; then  echo "Removing gstreamer registry after firmware update"; rm -rf /opt/.gstreamer; fi;'
 
 [Install]