RDK-59964 : ZeroConfig (IPv4LL) support for EntOS - AirPlay Devices by gururaajar · Pull Request #406 · rdkcentral/sysint

gururaajar · 2025-12-26T15:20:32Z

Reason for change: NetworkManager Dispatcher to launch avahi-autoipd to launch, when interface connected and clean-up IPv4LL when IPv4 is received.
Test Procedure: check whether link local IPv4 is assigned to wlan0 and eth0 when there is no valid IP.
Priority:P1
Risks: Medium

Reason for change: NetworkManager Dispatcher to launch avahi-autoipd to launch, when interface connected and clean-up IPv4LL when IPv4 is received. Test Procedure: check whether link local IPv4 is assigned to wlan0 and eth0 when there is no valid IP. Priority:P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…to topic/RDK-59964_new

Copilot

Pull request overview

This PR adds IPv4 Link-Local (ZeroConfig) support for CentOS-based AirPlay devices using avahi-autoipd. When network interfaces connect without receiving a valid IPv4 address via DHCP, a link-local IPv4 address (169.254.x.x) is automatically assigned. The implementation uses NetworkManager dispatcher to manage the lifecycle of avahi-autoipd services.

Changes:

Added new script to start avahi-autoipd when network interfaces come up without global IPv4
Modified NetworkManager dispatcher to stop avahi-autoipd when DHCP IPv4 is received
Configured DHCP timeout behavior for eth0 interface to support ZeroConfig fallback

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
lib/rdk/startLinkLocal.sh	New script that launches avahi-autoipd service for eth0/wlan0 interfaces when no global IPv4 is present
lib/rdk/NM_Dispatcher.sh	Added stop_zero_conf() function to clean up IPv4LL when DHCP IPv4 is acquired; adjusted DHCP timeout settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T03:30:18Z

lib/rdk/startLinkLocal.sh

+
+interfaceName=$1
+
+Log "From NM_preUp.sh $interfaceName"


The comment references 'NM_preUp.sh' but this script is 'startLinkLocal.sh'. This should be corrected to reference the actual script name.

Suggested change

Log "From NM_preUp.sh $interfaceName"

Log "From startLinkLocal.sh $interfaceName"

Copilot · 2026-01-15T03:30:19Z

lib/rdk/startLinkLocal.sh

+
+Log()
+{
+    echo "$(/bin/timestamp) : $0: $*" >> $LOG_FILE


The variable $LOG_FILE should be quoted to prevent word splitting and globbing issues if the path contains spaces or special characters. Use >> "$LOG_FILE" instead.

Suggested change

echo "$(/bin/timestamp) : $0: $*" >> $LOG_FILE

echo "$(/bin/timestamp) : $0: $*" >> "$LOG_FILE"

Copilot · 2026-01-15T03:30:19Z

lib/rdk/NM_Dispatcher.sh

+        if [[ "$interfaceName" == "eth0" ]]; then
+            WiredConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)
+            if [ -n "$WiredConnectionUUID" ]; then
+                nmcli connection modify "$WiredConnectionUUID" ipv4.dhcp-timeout 0
+                nmcli device reapply "$interfaceName"
+            fi
+        fi


This block sets DHCP timeout to 0 when DHCP is received, but there's no comment explaining why this is necessary or how it relates to the ZeroConfig cleanup. Adding a comment would improve maintainability, especially since startLinkLocal.sh sets it to 'infinity'.

…to topic/RDK-59964_new

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T03:47:14Z

lib/rdk/startLinkLocal.sh

+if [[ -n "$interfaceName" && ("$interfaceName" == "wlan0" || "$interfaceName" == "eth0") ]];then
+    if [[ "$interfaceName" == "eth0" ]];then


The condition syntax mixes POSIX test construct with bash-specific double brackets. For consistency with the shebang '#!/bin/sh' and broader portability, consider using POSIX-compliant syntax: if [ -n \"$interfaceName\" ] && { [ \"$interfaceName\" = \"wlan0\" ] || [ \"$interfaceName\" = \"eth0\" ]; }; then

Suggested change

if [[ -n "$interfaceName" && ("$interfaceName" == "wlan0" || "$interfaceName" == "eth0") ]];then

if [[ "$interfaceName" == "eth0" ]];then

if [ -n "$interfaceName" ] && { [ "$interfaceName" = "wlan0" ] || [ "$interfaceName" = "eth0" ]; }; then

if [ "$interfaceName" = "eth0" ]; then

Copilot · 2026-01-15T03:47:14Z

lib/rdk/startLinkLocal.sh

+if [[ -n "$interfaceName" && ("$interfaceName" == "wlan0" || "$interfaceName" == "eth0") ]];then
+    if [[ "$interfaceName" == "eth0" ]];then


The condition uses bash-specific double brackets and '==' operator. For consistency with the shebang '#!/bin/sh' and broader portability, use POSIX-compliant syntax: if [ \"$interfaceName\" = \"eth0\" ]; then

Suggested change

if [[ -n "$interfaceName" && ("$interfaceName" == "wlan0" || "$interfaceName" == "eth0") ]];then

if [[ "$interfaceName" == "eth0" ]];then

if [ -n "$interfaceName" ] && { [ "$interfaceName" = "wlan0" ] || [ "$interfaceName" = "eth0" ]; }; then

if [ "$interfaceName" = "eth0" ]; then

Copilot · 2026-01-15T03:47:15Z

lib/rdk/NM_Dispatcher.sh

+        if [[ "$interfaceName" == "eth0" ]]; then
+            WiredConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)
+            if [ -n "$WiredConnectionUUID" ]; then
+                nmcli connection modify "$WiredConnectionUUID" ipv4.dhcp-timeout 0
+                nmcli device reapply "$interfaceName"
+            fi
+        fi
+        if [[ "$interfaceName" == "wlan0" ]]; then
+            WifiConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)
+            if [ -n "$WifiConnectionUUID" ]; then
+                nmcli connection modify "$WifiConnectionUUID" ipv4.dhcp-timeout 0
+                nmcli device reapply "$interfaceName"
+            fi
+        fi


This code block contains significant duplication - the same logic is repeated for both eth0 and wlan0. Consider consolidating this into a single block that executes for both interfaces, reducing code duplication and improving maintainability.

Suggested change

if [[ "$interfaceName" == "eth0" ]]; then

WiredConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)

if [ -n "$WiredConnectionUUID" ]; then

nmcli connection modify "$WiredConnectionUUID" ipv4.dhcp-timeout 0

nmcli device reapply "$interfaceName"

fi

fi

if [[ "$interfaceName" == "wlan0" ]]; then

WifiConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)

if [ -n "$WifiConnectionUUID" ]; then

nmcli connection modify "$WifiConnectionUUID" ipv4.dhcp-timeout 0

nmcli device reapply "$interfaceName"

fi

fi

if [[ "$interfaceName" == "eth0" || "$interfaceName" == "wlan0" ]]; then

ConnectionUUID=$(nmcli -t -f UUID,DEVICE connection show --active | grep ":$interfaceName$" | cut -d: -f1)

if [ -n "$ConnectionUUID" ]; then

nmcli connection modify "$ConnectionUUID" ipv4.dhcp-timeout 0

nmcli device reapply "$interfaceName"

fi

fi

Copilot · 2026-01-15T03:47:15Z

lib/rdk/NM_Dispatcher.sh


 if [ "x$interfaceName" != "x" ] && [ "$interfaceName" != "lo" ]; then
    if [ "$interfaceStatus" == "dhcp4-change" ]; then
+        if [[ "$interfaceName" == "eth0" ]]; then


The condition uses bash-specific double brackets and '==' operator. For consistency with the shebang '#!/bin/sh' in this file and broader portability, use POSIX-compliant syntax: if [ \"$interfaceName\" = \"eth0\" ]; then

Copilot · 2026-01-15T03:47:15Z

lib/rdk/NM_Dispatcher.sh

+                nmcli device reapply "$interfaceName"
+            fi
+        fi
+        if [[ "$interfaceName" == "wlan0" ]]; then


The condition uses bash-specific double brackets and '==' operator. For consistency with the shebang '#!/bin/sh' in this file and broader portability, use POSIX-compliant syntax: if [ \"$interfaceName\" = \"wlan0\" ]; then

gururaajar requested a review from a team as a code owner December 26, 2025 15:20

gururaajar added 10 commits December 26, 2025 13:11

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

9ebb60f

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

9b55696

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

6ac5ec1

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

ab938eb

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

28f2533

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

afe1966

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

672701f

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

80b9fb9

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

b40f6dd

…to topic/RDK-59964_new

Copilot AI review requested due to automatic review settings January 15, 2026 03:28

Copilot started reviewing on behalf of gururaajar January 15, 2026 03:28 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

gururaajar added 3 commits January 14, 2026 22:41

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

077ea94

…to topic/RDK-59964_new

Merge branch 'topic/RDK-59964_new' of github.com:rdkcentral/sysint in…

7af5832

…to topic/RDK-59964_new

Merge branch 'develop' into topic/RDK-59964_new

c53e1cb

Copilot AI review requested due to automatic review settings January 15, 2026 03:43

Copilot started reviewing on behalf of gururaajar January 15, 2026 03:44 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDK-59964 : ZeroConfig (IPv4LL) support for EntOS - AirPlay Devices#406

RDK-59964 : ZeroConfig (IPv4LL) support for EntOS - AirPlay Devices#406
gururaajar wants to merge 14 commits intodevelopfrom
topic/RDK-59964_new

gururaajar commented Dec 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Log "From NM_preUp.sh $interfaceName"
	Log "From startLinkLocal.sh $interfaceName"

	echo "$(/bin/timestamp) : $0: $*" >> $LOG_FILE
	echo "$(/bin/timestamp) : $0: $*" >> "$LOG_FILE"

		if [[ -n "$interfaceName" && ("$interfaceName" == "wlan0" \|\| "$interfaceName" == "eth0") ]];then
		if [[ "$interfaceName" == "eth0" ]];then

Conversation

gururaajar commented Dec 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants