RDK-60476: Update L1 and L2 testcases for fork elimination by yogeswaransky · Pull Request #260 · rdkcentral/telemetry

yogeswaransky · 2026-02-11T13:14:07Z

No description provided.

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Updates unit tests to align with the new “fork elimination” HTTP implementation (connection-pool + libcurl), replacing older pipe/fork/read-based expectations and expanding the test mocks to interpose additional libcurl calls.

Changes:

Enable previously disabled xconf-client and protocol HTTP tests and update them to use curl/pool expectations instead of fork()/pipe().
Extend FileioMock interposition to cover curl_easy_getinfo() and curl_easy_setopt().
Add helper logic intended to avoid deadlocks when GTest/logging writes to FILE* while file I/O is mocked.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
`source/test/xconf-client/xconfclientTest.cpp`	Enables/updates `doHttpGet` tests to mock curl/pool behavior; adds a helper macro intended to prevent GTest logging deadlocks.
`source/test/protocol/ProtocolTest.cpp`	Updates protocol HTTP tests to mock curl/pool behavior; adds default curl behaviors in fixture setup and a helper macro/comment.
`source/test/mocks/FileioMock.h`	Adds/adjusts mock method signatures for curl interposition (`curl_easy_setopt`).
`source/test/mocks/FileioMock.cpp`	Adds interposed `curl_easy_getinfo()` and a new interposed `curl_easy_setopt()` implementation for tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/test/xconf-client/xconfclientTest.cpp

source/test/protocol/ProtocolTest.cpp

source/test/mocks/FileioMock.cpp

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/test/mocks/FileioMock.cpp

source/Makefile.am

source/test/protocol/ProtocolTest.cpp

source/test/leak_detection/README.md

source/test/leak_detection/DEVICE_INTEGRATION.md

source/test/leak_detection/curl_leak_test.c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/test/xconf-client/xconfclientTest.cpp

source/test/protocol/ProtocolTest.cpp

source/test/xconf-client/xconfclientTest.cpp

source/test/protocol/ProtocolTest.cpp

source/test/xconf-client/xconfclientTest.cpp

source/test/protocol/ProtocolTest.cpp

source/test/leak_detection/README.md

source/test/leak_detection/curl_leak_test.c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/test/xconf-client/xconfclientTest.cpp

source/test/protocol/ProtocolTest.cpp

source/test/xconf-client/xconfclientTest.cpp

source/test/leak_detection/DEVICE_INTEGRATION.md

source/Makefile.am

source/test/leak_detection/curl_leak_test.c

source/test/xconf-client/xconfclientTest.cpp

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/test/leak_detection/curl_leak_test.c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: yogeswaransky <yogeswaransky@gmail.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T14:35:37Z

source/test/xconf-client/xconfclientTest.cpp

+                return CURLE_OK;
+            });
+
+    //Add curl_easy_cleanup expectation


Comment style inconsistency: This comment starts with a lowercase letter ('Add') while most other comments in the file start with uppercase letters or follow proper capitalization rules. For consistency, it should be 'Add curl_easy_cleanup expectation' with proper capitalization.

Suggested change

//Add curl_easy_cleanup expectation

// Add curl_easy_cleanup expectation

source/protocol/http/multicurlinterface.c

Copilot · 2026-02-16T14:35:37Z

source/test/protocol/ProtocolTest.cpp

+      EXPECT_EQ(T2ERROR_SUCCESS, sendReportOverHTTP(httpURL, payload));
      free(payload);


Inconsistent indentation: these lines use 6 spaces for indentation while the surrounding code uses 4 spaces. The indentation should be consistent with the rest of the test function.

source/test/protocol/ProtocolTest.cpp

Copilot · 2026-02-16T14:35:39Z

source/test/xconf-client/xconfclientTest.cpp

-    })
-            .WillOnce(Return(-1));
-    EXPECT_EQ(T2ERROR_FAILURE, doHttpGet("https://test.com", &data));  
+    //Add curl_easy_cleanup expectation


Comment style inconsistency: This comment starts with a lowercase letter ('Add') while most other comments in the file start with uppercase letters or follow proper capitalization rules. For consistency, it should be 'Add curl_easy_cleanup expectation' with proper capitalization.

Suggested change

//Add curl_easy_cleanup expectation

// Add curl_easy_cleanup expectation

Copilot · 2026-02-16T14:35:40Z

source/protocol/http/multicurlinterface.c

    }

-    // Pre-allocate easy handles and initialize pool entries
+    // Allocating easy handles and initialize pool entries


Grammar issue: The comment should be 'Allocate easy handles and initialize pool entries' (with 'Allocate' in present tense to match 'initialize'). As written, 'Allocating' is a gerund/present participle while 'initialize' is a verb, creating a grammatical inconsistency.

Suggested change

// Allocating easy handles and initialize pool entries

// Allocate easy handles and initialize pool entries

Copilot · 2026-02-16T14:35:40Z

source/protocol/http/multicurlinterface.c

    }

    // Clean up certificates - only for non-LIBRDKCERTSEL_BUILD path
+    // In case of CertSelector, CertSelector will take care of freeing the certicates


Spelling error: 'certicates' should be 'certificates'.

Suggested change

// In case of CertSelector, CertSelector will take care of freeing the certicates

// In case of CertSelector, CertSelector will take care of freeing the certificates

Copilot · 2026-02-16T14:35:40Z

source/protocol/http/multicurlinterface.c

                CURL_SETOPT_CHECK(easy, CURLOPT_SSL_VERIFYPEER, 1L);

-                // Execute the request directly
+                // Execute the request and retry incase of certificate related error


Spelling error: 'incase' should be two words: 'in case'.

Suggested change

// Execute the request and retry incase of certificate related error

// Execute the request and retry in case of certificate related error

Copilot · 2026-02-16T14:35:40Z

source/test/protocol/ProtocolTest.cpp

+      EXPECT_EQ(T2ERROR_SUCCESS, sendReportOverHTTP(httpURL, payload));
      free(payload);


Inconsistent indentation: these lines use 6 spaces for indentation while the surrounding code uses 4 spaces. The indentation should be consistent with the rest of the test function.

RDK-60476: Update L1 and L2 testcases for fork elimination

0c905b2

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 11, 2026 13:14

yogeswaransky requested a review from a team as a code owner February 11, 2026 13:14

Copilot started reviewing on behalf of yogeswaransky February 11, 2026 13:14 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

yogeswaransky added 2 commits February 13, 2026 20:00

RDK-60476: Update L1 and L2 testcases for fork elimination

1de72ea

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDK-60476: Update L1 and L2 testcases for fork elimination

308f165

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 13, 2026 20:05

Copilot started reviewing on behalf of yogeswaransky February 13, 2026 20:06 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

rdkcmf-jenkins reviewed Feb 13, 2026

View reviewed changes

source/test/leak_detection/curl_leak_test.c Outdated Show resolved Hide resolved

yogeswaransky added 2 commits February 13, 2026 20:21

RDK-60476: Update L1 and L2 testcases for fork elimination

7e4161c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDK-60476: Update L1 and L2 testcases for fork elimination

e5830f2

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 15, 2026 07:38

Copilot started reviewing on behalf of yogeswaransky February 15, 2026 07:38 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

rdkcmf-jenkins reviewed Feb 15, 2026

View reviewed changes

source/test/leak_detection/curl_leak_test.c Outdated Show resolved Hide resolved

yogeswaransky added 2 commits February 15, 2026 09:56

RDK-60476: Update L1 and L2 testcases for fork elimination

33b954c

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDK-60476: Update L1 and L2 testcases for fork elimination

2e8c436

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 15, 2026 10:48

Copilot started reviewing on behalf of yogeswaransky February 15, 2026 10:48 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

yogeswaransky added 2 commits February 15, 2026 15:57

RDK-60476: Update L1 and L2 testcases for fork elimination

bbae086

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDK-60476: Update L1 and L2 testcases for fork elimination

441fa38

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 15, 2026 16:14

Copilot started reviewing on behalf of yogeswaransky February 15, 2026 16:14 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

source/test/leak_detection/curl_leak_test.c Outdated Show resolved Hide resolved

yogeswaransky added 2 commits February 15, 2026 17:01

RDK-60476: Update L1 and L2 testcases for fork elimination

10af6b8

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

RDK-60476: Update L1 and L2 testcases for fork elimination

ee02b0e

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 15, 2026 17:46

Copilot started reviewing on behalf of yogeswaransky February 15, 2026 17:46 View session

Copilot AI reviewed Feb 15, 2026

View reviewed changes

yogeswaransky added 2 commits February 16, 2026 13:20

RDK-60476: Update L1 testcases for fork elimination

00aac3d

Signed-off-by: yogeswaransky <yogeswaransky@gmail.com>

RDK-60476: Update L1 testcases for fork elimination

93d8643

Signed-off-by: yogeswaransky <yogeswaransky@gmail.com>

Copilot AI review requested due to automatic review settings February 16, 2026 14:29

Copilot started reviewing on behalf of yogeswaransky February 16, 2026 14:29 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

	//Add curl_easy_cleanup expectation
	// Add curl_easy_cleanup expectation

		EXPECT_EQ(T2ERROR_SUCCESS, sendReportOverHTTP(httpURL, payload));
		free(payload);

	// Allocating easy handles and initialize pool entries
	// Allocate easy handles and initialize pool entries

	// In case of CertSelector, CertSelector will take care of freeing the certicates
	// In case of CertSelector, CertSelector will take care of freeing the certificates

	// Execute the request and retry incase of certificate related error
	// Execute the request and retry in case of certificate related error

Conversation

yogeswaransky commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026