Draft: add rdmo.config app for Plugin model
#1436
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
jochenklar
requested changes
Oct 9, 2025
rdmo/config/models.py
Outdated
| help_text=_('Designates whether this plugin is generally available for projects.') | ||
| ) | ||
|
|
||
| class PluginType(models.TextChoices): |
There was a problem hiding this comment.
I think we can do without this, the Plugin(-class) should know this.
jochenklar
reviewed
Oct 9, 2025
| verbose_name=_("Python path"), | ||
| ) | ||
| plugin_type = models.CharField(max_length=32, choices=PluginType.choices) | ||
|
|
There was a problem hiding this comment.
But what we need to add is plugin_settings which is used to set the settings for this plugin.
MyPyDavid
changed the title
rdmo.config app for Plugin model
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
|
I'm getting some strange DB errors for mysql in ci(and sqlite in local testing). django.db.utils.OperationalError: foreign key mismatch - "questions_question" referencing "domain_attribute"From the ci logs: # at
query = b'ALTER TABLE `domain_attribute` DROP COLUMN `attributeentity_ptr_id`' django.db.utils.OperationalError:
(1829, "Cannot drop column 'attributeentity_ptr_id':
needed in a foreign key constraint 'questions_questionse_attribute_id_30ee3ea9_fk_domain_at' of table 'questions_questionset'")The problem can be resolved by removing the app |
Signed-off-by: David Wallace <[email protected]>
Signed-off-by: David Wallace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #1413