Fix incorrect "kicked" modlog when users leave #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here was checking whether a return value existed, but I got things twisted as I refactored and had added a "left" case. So members that leave the server are being incorrectly logged as kicked.
Strictly speaking, we could in fact open a new thread for every member, thus capturing their entire membership journey — when they join, when the leave (or are removed), any automod triggers… The downside is that it becomes a little bit more "proactive surveillance" vs "incident recording", and in general I prefer to avoid surveillance