Add cognitive complexity #6210
Open
Add cognitive complexity #6210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Add cognitive complexity.
[samglt](https://github.com/samglt)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a previous PR #5838 hasn't been updated in a while, here is a modification to that PR with the visitor pulled out for testing as suggested here.
I changed the visitor itself slightly to get it closer to the described algorithm in #3335. I believe it covers everything relevant to Swift except recursion and sequences of logical operators outside of if/guard statement conditions.
My changes generally lower the complexity levels compared to the above PR, but I don't know if the current warning and error levels of 15 & 20 are too high or low or if they should be spread out.
I also wonder if closures increasing nesting should be optional, since SwiftUI views are naturally full of nested closures. IMO the cognitive cost of nested views is not as big as nested conditionals and loops, but maybe it's not an issue since nested closures only add to the nesting level and don't have a cost by themselves.