correct incorrect handling of file paths #6355
Open
+29
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Here's an example of your CHANGELOG entry: * correct incorrect handling of file paths.
[compnerd](https://github.com/compnerd)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
compnerd
force-pushed
the
path
branch
2 times, most recently
from
38c399c to
8e2e62c
Compare
`URL.path` is not a usable rendering of the path. `URL.path` represents the URI path. If the path is meant to be consumable as a file path, the file system representation (aka FSR) must be retrieved. This improves the file path handling and makes additional tests now pass.
Contributor
Author
|
@SimplyDanny I think that I will need a little bit of help here. The current failure seems to be unrelated to my change and might be a general configuration issue. It does seem that this change is passing the CI and does improve the test coverage on Windows. I'm not sure that brace expansion is required - the musl path does not support that either. Please let me know if there is anything else that this needs. |
Collaborator
|
I think this was just a hiccup in the pipeline. Works now after retriggering it. I'll have a look at the changes later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL.pathis not a usable rendering of the path.URL.pathrepresents the URI path. If the path is meant to be consumable as a file path, the file system representation (aka FSR) must be retrieved.Unfortunately, the FSR access is a bit more complicated as the API for that returns a +0 borrowed object with the lifetime bound to
URL. Because this relies on the toll-free bridged storage ofURL, Swift does not have this. Instead, we are provided awithUnsafeFileSystemRepresentationwhich provides a heap allocated buffer that is scoped, which we can copy into aString. To abstract away this wart, we introduce an extension onURLto access the FSR through the newfilepathproperty.This improves the file path handling and makes additional tests now pass.