Adds Variable Shadowing Rule#6568
Merged
SimplyDanny merged 18 commits intorealm:mainfrom Apr 13, 2026
Merged
Conversation
Generated by 🚫 Danger |
SimplyDanny
requested changes
Apr 1, 2026
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Nice one! Glad to see that DeclaredIdentifiersTrackingVisitor is used for more advanced rules.
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
reviewed
Apr 7, 2026
3553d5d to
eb602f2
Compare
SimplyDanny
requested changes
Apr 9, 2026
Tests/IntegrationTests/Resources/default_rule_configurations.yml
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/VariableShadowingRule.swift
Outdated
Show resolved
Hide resolved
5bcb7bf to
fd51bd2
Compare
…swift Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
…swift Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
…swift Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
…swift Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
bcd25dd to
d28ac00
Compare
SimplyDanny
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
variable_shadowingrule that detects when a variable declaration shadows an identifier from an outer scope.Changes
VariableShadowingRule.swift- flags variable declarations that shadow outer scope identifiersBuiltInRules.swiftGeneratedTests_10.swiftdefault_rule_configurations.ymlCHANGELOG.mdExample
Resolves #6228