Fix false positive in accessibility_label_for_image for SwiftUI Lab…#6594
Open
sutheesh wants to merge 1 commit intorealm:mainfrom
Open
Fix false positive in accessibility_label_for_image for SwiftUI Lab…#6594sutheesh wants to merge 1 commit intorealm:mainfrom
accessibility_label_for_image for SwiftUI Lab…#6594sutheesh wants to merge 1 commit intorealm:mainfrom
Conversation
sutheesh
force-pushed
the
enhancements/6420
branch
from
30e5543 to
0ce5790
Compare
Generated by 🚫 Danger |
…el icon closures Images inside a `Label`'s `icon:` closure are inherently labeled by the Label's text content and do not need a separate accessibility label. Adds `isInsideLabelIconClosure()` to detect this pattern via SwiftSyntax and exempts matching images from the rule, with three new non-triggering examples covering `systemName`, asset name, and `uiImage` variants. Fixes realm#6420
sutheesh
force-pushed
the
enhancements/6420
branch
from
0ce5790 to
3c52aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…el icon closures
Images inside a
Label'sicon:closure are inherently labeled by the Label's text content and do not need a separate accessibility label. AddsisInsideLabelIconClosure()to detect this pattern via SwiftSyntax and exempts matching images from the rule, with three new non-triggering examples coveringsystemName, asset name, anduiImagevariants.Fixes #6420