fix/iOS: Load realm-wrapper DLL using MainBundle.PrivateFrameworksPath #3714
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @EmilienDup. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3711.
Allows Realm to work in net10-ios apps.
This change is minimal.
It is based on this comment.
Ideally I think it would have been better to delegate the wrappers initialization to the platform level (Windows & iOS).
But as the platform level code is not part of the main assembly, changing the resolver of another assembly is not recommended.
As I am developing on a Mac, I encountered a lot of hiccups when trying to build the various projects.
Based on my testings it should work fine on net8-ios and net10-ios, but if it is possible to generate nuget packages from my PR, I would like to test them in a standalone app to make sure everything works well once packaged up.
TODO