fix: Allow any len for compute sizes param when asking for spot #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@ppitonak this should help you to reduce the number of machines set on ComputeSize now the minimum should be 3 from there you should not need such a long list |
ppitonak
reviewed
Nov 19, 2025
Collaborator
ppitonak
left a comment
ppitonak
left a comment
There was a problem hiding this comment.
How/where is 3 enforced? In mapt or on API level?
Collaborator
Author
|
Yeah actually It is not imposed, I just tried with 2 and it worked..so let me change the commit message |
Previously there was a fixed value to 8 on spot calculations, now if computeSizes are pass as param and the number of sizes is less than 8 it will use the len of compute sizes. This means now we will be able to use any number of compute sizes. Fix redhat-developer#622 Signed-off-by: Adrian Riobo <[email protected]>
adrianriobo
changed the title
ppitonak
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a fixed value to 8 on spot calculations, now if computeSizes are pass as param and the number of sizes is less than 8 it will use the len of compute sizes. This means now we will be able to use any number of compute sizes.
Fixes #622
Signed-off-by: Adrian Riobo [email protected]