-
Notifications
You must be signed in to change notification settings - Fork 6
tests: pr-build-extension workflow for PR check #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
odockal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal is quite good! we just need some improvements.
.github/workflows/pr-check.yaml
Outdated
| working-directory: image-checker-extension/podman-desktop-extension | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Checkout the podman-desktop repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up: would be great to use testing-prereleases binaries.
fd2e89b to
ba92313
Compare
9acc1f5 to
700d0be
Compare
621f699 to
0932f23
Compare
odockal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Signed-off-by: Rostislav Lán <[email protected]>
jeffmaury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding build_extension workflow as per #60