Skip to content

Conversation

@rostalan
Copy link
Contributor

@rostalan rostalan commented May 27, 2025

Adding build_extension workflow as per #60

@rostalan rostalan requested a review from a team as a code owner May 27, 2025 00:09
@rostalan rostalan requested review from axel7083, Copilot, dgolovin, feloy, jeffmaury and odockal and removed request for axel7083, dgolovin and feloy May 27, 2025 00:09

This comment was marked as outdated.

@rostalan
Copy link
Contributor Author

Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal is quite good! we just need some improvements.

working-directory: image-checker-extension/podman-desktop-extension
run: yarn install --frozen-lockfile

- name: Checkout the podman-desktop repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up: would be great to use testing-prereleases binaries.

@rostalan rostalan marked this pull request as draft May 27, 2025 08:03
@rostalan rostalan closed this May 27, 2025
@rostalan rostalan reopened this May 28, 2025
@rostalan rostalan force-pushed the main branch 3 times, most recently from fd2e89b to ba92313 Compare May 28, 2025 11:43
@rostalan rostalan marked this pull request as ready for review May 28, 2025 11:44
@rostalan rostalan force-pushed the main branch 6 times, most recently from 9acc1f5 to 700d0be Compare May 29, 2025 10:57
@rostalan rostalan closed this May 29, 2025
@rostalan rostalan force-pushed the main branch 15 times, most recently from 621f699 to 0932f23 Compare May 30, 2025 13:39
@rostalan rostalan changed the title PR check workflow with e2e tests tests: build workflow for PR check Jun 26, 2025
@rostalan rostalan changed the title tests: build workflow for PR check tests: pr-build-extension workflow for PR check Jun 26, 2025
@rostalan rostalan requested a review from odockal June 27, 2025 17:18
Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@odockal odockal enabled auto-merge July 3, 2025 16:20
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odockal odockal merged commit 2599340 into redhat-developer:main Jul 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants