Skip to content

Conversation

@SoniaSandler
Copy link
Contributor

@SoniaSandler SoniaSandler commented Apr 8, 2025

This PR updates existing code to use the newly added VM types in the Podman Desktop API

Closes #7

Needs to be rebase after #37 is merged

@SoniaSandler SoniaSandler force-pushed the update-podmandesktopAPI branch 3 times, most recently from 8c6b54f to 9ffd9a1 Compare April 14, 2025 00:59
@SoniaSandler SoniaSandler marked this pull request as ready for review April 14, 2025 12:31
@feloy feloy self-requested a review April 14, 2025 12:34
@feloy
Copy link
Contributor

feloy commented Apr 14, 2025

You will need to change the scope of properties in package.json from ContainerProviderConnectionFactory to VmProviderConnectionFactory, to make them appear in the Create new VM form (see https://github.com/redhat-developer/podman-desktop-rhel-ext/pull/10/files)

@SoniaSandler
Copy link
Contributor Author

@feloy I thought I did it, but maybe it was on another branch I was working on, will do it now

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. Thanks

@benoitf benoitf merged commit 73ca3db into redhat-developer:main Apr 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt extension to use the new virtual machine API

3 participants