feat: use cached image if it exists #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feloy
force-pushed
the
feat-45/use-cached-image
branch
from
a4fb373 to
0188252
Compare
feloy
force-pushed
the
feat-45/use-cached-image
branch
from
0188252 to
a9d0a44
Compare
SoniaSandler
approved these changes
May 2, 2025
Contributor
SoniaSandler
left a comment
SoniaSandler
left a comment
There was a problem hiding this comment.
LGTM, tested and it works as intended.
Question (nit): should we add some indication (probably in a later PR) that the image-path field in the creation form is optional and if nothing is provided it'll try to use the cached image if it exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #45
If an image named
~/.local/share/containers/podman-desktop/extensions-storage/redhat.macadam/images/imageis found and no image is given by the user in creation form, this image will be used.This is a first step towards downloading the image from repository and caching it in the user's FS
To test it, you can copy a RHEL image compatible with your platform in the directory
~/.local/share/containers/podman-desktop/extensions-storage/redhat.macadam/images/, by renaming it asimage, then create a VM without specifying an image path.