-
Notifications
You must be signed in to change notification settings - Fork 10
chore: update PR jobs to run build script and generate files #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update PR jobs to run build script and generate files #87
Conversation
Signed-off-by: Sonia Sandler <[email protected]>
benoitf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, AFAIk generated sources should not be committed (should be in src-gen, not in src)
|
@benoitf that was the first thing I did, but I think it was the linter that failed as the generated file was imported but didn't exist https://github.com/redhat-developer/podman-desktop-rhel-ext/actions/runs/14770043428 |
|
@SoniaSandler yes , as you said, it seems it would be nice if: either the linter command generates the file first or that the job calls the build command first as long as generated files are not committed I would say, we're fine 👍 ' |
|
@benoitf okay, I'll remove the generated file from this repo and update the workflows |
|
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as it's an intermediate step to unblock gh jobs, removal can be a separate PR
Signed-off-by: Sonia Sandler <[email protected]>
|
@benoitf updated the PR workflows and removed the generated files. Merging as all the PR checks pass |
Main build job failed because of a permission error with the
pnpm generate:subscription-v1part of the build script. Now the generated files are not committed to this repo and the build script has been added to all pr jobs