Skip to content

Conversation

@SoniaSandler
Copy link
Contributor

@SoniaSandler SoniaSandler commented May 2, 2025

Main build job failed because of a permission error with the pnpm generate:subscription-v1 part of the build script. Now the generated files are not committed to this repo and the build script has been added to all pr jobs

@SoniaSandler SoniaSandler requested a review from feloy May 2, 2025 15:34
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, AFAIk generated sources should not be committed (should be in src-gen, not in src)

@SoniaSandler
Copy link
Contributor Author

SoniaSandler commented May 2, 2025

@benoitf that was the first thing I did, but I think it was the linter that failed as the generated file was imported but didn't exist https://github.com/redhat-developer/podman-desktop-rhel-ext/actions/runs/14770043428
(Edit: I could add a pnpm build step in the PR check jobs to generate it)

@benoitf
Copy link
Collaborator

benoitf commented May 2, 2025

@SoniaSandler yes , as you said, it seems it would be nice if: either the linter command generates the file first or that the job calls the build command first

as long as generated files are not committed I would say, we're fine 👍 '

@SoniaSandler
Copy link
Contributor Author

@benoitf okay, I'll remove the generated file from this repo and update the workflows

@SoniaSandler SoniaSandler marked this pull request as draft May 2, 2025 16:01
@benoitf
Copy link
Collaborator

benoitf commented May 2, 2025

thanks

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as it's an intermediate step to unblock gh jobs, removal can be a separate PR

@SoniaSandler SoniaSandler marked this pull request as ready for review May 2, 2025 16:07
@SoniaSandler SoniaSandler changed the title chore: remove generate:subscription-v1 from build script chore: update PR jobs to run build script and generate files May 2, 2025
@SoniaSandler
Copy link
Contributor Author

@benoitf updated the PR workflows and removed the generated files. Merging as all the PR checks pass

@SoniaSandler SoniaSandler merged commit aec5822 into redhat-developer:main May 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants