Skip to content

Conversation

@josephca
Copy link
Member

@josephca josephca commented Nov 19, 2025

@josephca josephca requested a review from nickboldt November 19, 2025 16:23
@josephca josephca requested review from a team, gashcrumb and kadel as code owners November 19, 2025 16:23
@josephca josephca changed the title rename plugin files by using the shortened naming convention and update all.yaml rename plugin files by using the shortened naming convention and update referenced files Nov 19, 2025
@github-actions github-actions bot added the non-workspace-changes PR changes files outside workspace directories label Nov 20, 2025
@polasudo
Copy link
Contributor

can we please document this convention maybe something like this
bitbucket -> bbckt
so we know what is short for what

@josephca
Copy link
Member Author

can we please document this convention maybe something like this bitbucket -> bbckt so we know what is short for what

mapping is borrowed from https://github.com/redhat-developer/rhdh-plugin-export-utils/blob/main/common/scripts/shorten-component-name.sh

Anyways, I'll make another update to fix only files with names that needed to be truncated to work around Openshift 63-char length limits.

@josephca josephca marked this pull request as draft November 21, 2025 16:19
@josephca josephca force-pushed the RHIDP-9492-rename-catalog-entities branch from 3d76f1f to 6bb24d2 Compare November 21, 2025 19:38
@josephca josephca marked this pull request as ready for review November 21, 2025 19:40
@github-actions github-actions bot removed the non-workspace-changes PR changes files outside workspace directories label Nov 22, 2025
@josephca josephca force-pushed the RHIDP-9492-rename-catalog-entities branch from 6bb24d2 to 01980ac Compare November 24, 2025 14:18
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems OK but a bit weird that you renamed the MCP package and it's not appearing in the all.yaml file. We should probably sync that file from the downstream generated copy or just delete the file as it's no longer useful in the overlays repo.

See #1630

@nickboldt nickboldt merged commit 8b71693 into redhat-developer:main Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants