Skip to content

Conversation

AndrienkoAleksandr
Copy link
Contributor

Hey, I just made a Pull Request!

Prefer to use use configuration integration to determine approval tool, instead of hard-coded "gitlab" host.

What does this pull request fix

Fix issue: https://issues.redhat.com/browse/RHIDP-9359

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Oct 16, 2025

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-bulk-import-backend

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-bulk-import-backend workspaces/bulk-import/plugins/bulk-import-backend none v6.5.1

@sonarqubecloud
Copy link

Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the better way to do it, but what happens if both git and gitlab are configured at the same time?

@AndrienkoAleksandr
Copy link
Contributor Author

Yes, I initially tested this PR with both GitLab and GitHub enabled at the same time, and it worked in my case.
If you see a scenario where it might not work, could you please share more details?

I created this PR because I expected that the bulk-import should work with a configuration like:

integrations:
  gitlab:
    - host: gitlab.com
      token: 'some-token'
    - host: my.personal.gitlab.com
      token: 'some-token'
  github:
    - host: github.com
      token: 'github token'

@lholmquist
Copy link
Member

i guess i was confused on if you had both gitlab and github configured, then you tried to import repo's from github, it looks like the code will see the gitlab configuration and then return thinking it should import from gitlab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants