fix(catalog): docs tab content used a double margin on the right side when the quickstart was open #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the quickstart was open Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
requested review from
a team,
divyanshiGupta and
its-mitesh-kumar
as code owners
Changed Packages
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
TechDocs integration under Docs was fine, but Docs tab in the catalog looked "strange" before.
The issue was that that there is a margin-right rule for the content that reacts on any main tag, but in the case of techdocs in the catalog there are two of these.
In RHDH:
The RHDH fix is here: redhat-developer/rhdh#3755
That PR fixes https://issues.redhat.com/browse/RHDHBUGS-2319
This PR here fixes the same problem in the quickstart test backstage app:
Before:
With this PR:
✔️ Checklist
Changeset is not needed because this PR doesn't touch the plugin itself.