-
Couldn't load subscription status.
- Fork 205
chore(app): extract out config parsing #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d15eb73 to
609c322
Compare
|
The image is available at: |
609c322 to
cff3d8a
Compare
133c468 to
02f0b13
Compare
02f0b13 to
cc72381
Compare
cc72381 to
5c8885b
Compare
|
The image is available at: |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
@gashcrumb let me wait for your rebase, and finally start reviewing this. |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
/hold |
|
The image is available at: |
|
/unhold |
|
/hold |
This change extracts out the frontend configuration parsing functions into a separate app-utils package, to prepare making the old RHDH dynamic frontend configuration available to the new frontend system configuration bridge when it is implemented. Signed-off-by: Stan Lewis <[email protected]>
|
The image is available at: |
|
@gashcrumb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This change extracts out the frontend configuration parsing functions into a separate app-utils package, to prepare making the old RHDH dynamic frontend configuration available to the new frontend system configuration bridge when it is implemented.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
There should be no apparent app behavior changes