Skip to content

Conversation

@gashcrumb
Copy link
Member

@gashcrumb gashcrumb commented Sep 4, 2025

Description

This change extracts out the frontend configuration parsing functions into a separate app-utils package, to prepare making the old RHDH dynamic frontend configuration available to the new frontend system configuration bridge when it is implemented.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

There should be no apparent app behavior changes

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Sep 23, 2025
@davidfestal
Copy link
Member

@gashcrumb let me wait for your rebase, and finally start reviewing this.

@github-actions github-actions bot removed the Stale label Sep 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@gashcrumb
Copy link
Member Author

/hold

@github-actions
Copy link
Contributor

@gashcrumb
Copy link
Member Author

/unhold

@gashcrumb
Copy link
Member Author

/hold
probably would be good to wait until post 1.8 to merge this, as it'll complicate back-porting changes to the frontend.

This change extracts out the frontend configuration parsing functions
into a separate app-utils package, to prepare making the old RHDH
dynamic frontend configuration available to the new frontend system
configuration bridge when it is implemented.

Signed-off-by: Stan Lewis <[email protected]>
@github-actions
Copy link
Contributor

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@gashcrumb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 5c8885b link true /test e2e-tests
ci/prow/e2e-ocp-helm a4de003 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants