Skip to content

Conversation

@gabemontero
Copy link
Contributor

Description

f/up from discussion with @nickboldt in #3512 about using release specific tags now that they are available

I've tested these image ref's on RHDH running on OCP

there was also a last minute upd for the model catalog plugin that took it from 0.6.0 to 0.7.0

@johnmcollier FYI

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gabemontero gabemontero force-pushed the ai-integ-official-tags branch from 56f7967 to 24378c2 Compare October 17, 2025 15:08
@gabemontero gabemontero changed the title feat(ai-integrations) update AI Model Catalog marketplace to release specific tags feat(ai-integrations): update AI Model Catalog marketplace to release specific tags Oct 17, 2025
@gabemontero
Copy link
Contributor Author

/assign @nickboldt

@gabemontero
Copy link
Contributor Author

/assign @johnmcollier

@github-actions
Copy link
Contributor

@gabemontero
Copy link
Contributor Author

/retest

@github-actions
Copy link
Contributor

@gabemontero
Copy link
Contributor Author

/retest

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@christoph-jerolimov
Copy link
Member

/retest
/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/retest
/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gabemontero
Copy link
Contributor Author

there seems to be a perm fail in the showcase-rbac e2e's which best to my knowledge would not be impacted by my changes

also seeing various showcase e2e failures in other currently open PRs

I see some tests were disabled yesterday ... will try to rebase see if that helps

@github-actions
Copy link
Contributor

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gabemontero gabemontero force-pushed the ai-integ-official-tags branch from 73c5943 to 62b7b8e Compare October 27, 2025 15:44
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

@gabemontero
Copy link
Contributor Author

/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@gabemontero: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gabemontero
Copy link
Contributor Author

@nickboldt @christoph-jerolimov - not that I would profess to being an SME in processing e2e-ocp-helm issues, but I think this PR is stuck on unrelated errors ... I rebased a couple of times (even though I lost my lgtm from @christoph-jerolimov in the process) but that has had no effect

any suggestions on how I might solicit assistance to get past this?

thanks

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

@nickboldt @christoph-jerolimov - not that I would profess to being an SME in processing e2e-ocp-helm issues, but I think this PR is stuck on unrelated errors ... I rebased a couple of times (even though I lost my lgtm from @christoph-jerolimov in the process) but that has had no effect

any suggestions on how I might solicit assistance to get past this?

thanks

finally got a clean e2e-ocp-helm run

@christoph-jerolimov @nickboldt @johnmcollier @benwilcock can I get a reapplication of the lgtm so we can get this merged?

thanks

@nickboldt nickboldt added the lgtm label Oct 29, 2025
@nickboldt nickboldt merged commit 7187644 into redhat-developer:main Oct 29, 2025
11 of 13 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@christoph-jerolimov: new pull request created: #3642

In response to this:

/retest
/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants