Skip to content

Conversation

@gustavolira
Copy link
Member

Description

QE work needed for: Deprecate OCM plugin from rhdh plugin catalog + wrapper

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from albarbaro and zdrapela October 20, 2025 14:36
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign josephca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gustavolira gustavolira changed the title RHIDP-9235 Deprecate OCM plugin from rhdh plugin catalog chore(e2e): rhidp-9235 Deprecate OCM plugin from rhdh plugin catalog Oct 20, 2025
@gustavolira
Copy link
Member Author

I ran npx prettier --write . into the .ibm folder, so that's why some unrelated files was included into this PR

@gustavolira
Copy link
Member Author

/test e2e-ocp-helm

@qodo-merge-pro
Copy link

You are above your monthly Qodo Merge usage quota. For more information, please visit here.

@zdrapela
Copy link
Member

I ran npx prettier --write . into the .ibm folder, so that's why some unrelated files was included into this PR

Hi, we currently have Prettier configured to run only on sh,md,yaml,yml files (see

"prettier:fix": "npx prettier --write **/*.{sh,md,yaml,yml}"
), because we only have rules configured for these files: https://github.com/redhat-developer/rhdh/blob/main/.ibm/.prettierrc.js

We can surely expand this to different filetypes, but until we do, I'd rather use yarn prettier:fix for this purpose, as the recommended way.

@zdrapela
Copy link
Member

/test e2e-ocp-helm

Copy link
Member

@zdrapela zdrapela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't include the changes from prettier for files outside the scope of this PR (see my previous comment), but apart from that, the PR looks good.
Let's see if the tests will pass

@zdrapela
Copy link
Member

/test e2e-eks-helm-nightly

@zdrapela
Copy link
Member

/test e2e-ocp-operator-nightly

@github-actions
Copy link
Contributor

@zdrapela
Copy link
Member

/test e2e-eks-helm-nightly
/test e2e-ocp-operator-nightly

@zdrapela
Copy link
Member

Looks good on both OCP and K8s jobs. Only needs a rebase

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@gustavolira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-eks-helm-nightly 45d7cf1 link false /test e2e-eks-helm-nightly
ci/prow/e2e-ocp-operator-nightly 45d7cf1 link false /test e2e-ocp-operator-nightly
ci/prow/e2e-ocp-helm 45d7cf1 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants