Skip to content

[build] replace 'shelljs''s which with 'which' API #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[build] replace 'shelljs''s which with 'which' API #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/esbuild.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ if (production) {
platform: 'node',
entryPoints: [`./${srcDir}/extension.ts`],
outfile: `${outDir}/${srcDir}/extension.js`,
external: [ 'vscode', 'shelljs', 'jsonc-parser' ],
external: [ 'vscode', 'jsonc-parser' ],
plugins: [
nativeNodeModulesPlugin,
esbuildProblemMatcherPlugin // this one is to be added to the end of plugins array
Expand Down
3 changes: 1 addition & 2 deletions build/verify-tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import * as fs from 'fs-extra';
import * as mkdirp from 'mkdirp';
import * as os from 'os';
import * as path from 'path';
import { exit } from 'shelljs';
import { DownloadUtil } from '../src/downloadUtil/download';
import * as configData from '../src/tools.json';
import { hashFile } from '../src/util/utils';
Expand Down Expand Up @@ -72,7 +71,7 @@ cp.exec('git diff --name-only origin/master -- .', async (error, stdout) => {
try {
await verifyTools();
} catch {
exit(1);
process.exit(1);
}
} else {
console.log('tools.json is not changed, skipping download verification');
Expand Down
Loading