Skip to content

Conversation

skestwal
Copy link
Collaborator

@skestwal skestwal commented Oct 3, 2025

… replicas to single tuple convention

… replicas to single tuple convention

Signed-off-by: skestwal <[email protected]>
Copy link

openshift-ci bot commented Oct 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@skestwal skestwal changed the title refactor(RHIDH-9114): change two variable convention for db and scale… refactor(RHIDH-9114): change two variable convention to tuple for DB and Scale replica Oct 3, 2025
Copy link

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skestwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2025
@skestwal skestwal marked this pull request as ready for review October 3, 2025 10:15
@skestwal skestwal changed the title refactor(RHIDH-9114): change two variable convention to tuple for DB and Scale replica RHIDP-8793: change two variable convention to tuple for DB and Scale replica Oct 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 3, 2025

@skestwal: This pull request references RHIDP-8793 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

… replicas to single tuple convention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skestwal skestwal changed the title RHIDP-8793: change two variable convention to tuple for DB and Scale replica RHIDP-9114: change two variable convention to tuple for DB and Scale replica Oct 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 3, 2025

@skestwal: This pull request references RHIDP-9114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

… replicas to single tuple convention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

IFS=":" read -ra tokens <<<"${a_c}"
a="${tokens[0]}" # apis
[[ "${#tokens[@]}" == 1 ]] && c="" || c="${tokens[1]}" # components
index="${r}r-${dbr}dbr-db_${s}-${bu}bu-${bg}bg-${rbs}rbs-${w}w-${cr}cr-${cl}cl-${mr}mr-${ml}ml-${a}a-${c}c"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skestwal Please keep the number of db replicas in the index

export WORKERS=$w
export API_COUNT=$a
export COMPONENT_COUNT=$c
index="${r}r-${dbr}dbr-db_${s}-${bu}bu-${bg}bg-${rbs}rbs-${w}w-${cr}cr-${cl}cl-${mr}mr-${ml}ml-${a}a-${c}c"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skestwal Please keep the number of db replicas in the index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants