Adjust console logging format when running under systemd #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
systemd-journal-logging
branch
from
a8f3ee3 to
ef0ec6a
Compare
rvl
force-pushed
the
systemd-journal-logging
branch
from
ef0ec6a to
abcb00b
Compare
rvl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most systemd services write their logs to the systemd journal by default. I think tuned should do likewise, because users would expect this, and it's useful to be able to read tuned logs together with other system logs.
So this PR changes the systemd services to remove the
-l(log to/var/log/tuned/tuned.log) option.It also adds a systemd-specific log formatter, which is only enabled when running in a systemd service and logging to console.
I chose not to use the
python-systemdmodule because the extra dependency can be avoided with very little code.