Bsb/upgrade vl in lock #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_async_alist_with_deserialization test was incorrectly marked as skipped with a misleading comment claiming that alist() deserialization was not addressed in PR #87. However, the fix was already implemented in the alist() method via _recursive_deserialize() call at line 742 of aio.py. This commit: - Removes the @pytest.mark.skip decorator - Updates the docstring to accurately reflect that the fix is implemented - Ensures the test runs and validates proper message deserialization The test passes successfully, confirming that alist() properly deserializes LangChain messages when listing checkpoints.
…96) Issue #96 reported AttributeError: 'ClusterPipeline' object has no attribute 'nodes_manager' when using AsyncRedisStore with Redis Cluster. The issue was fixed upstream in redisvl 0.9.0 via redisvl issue #365, which added a safe wrapper around get_protocol_version() to handle ClusterPipeline objects that don't have the nodes_manager attribute. This commit adds comprehensive regression tests to prevent this issue from recurring: - test_async_store_batch_put_no_attribute_error: Tests standalone mode - test_async_store_cluster_mode_batch_put: Tests cluster mode (exact scenario from #96) - test_async_store_large_batch_cluster_mode: Stress tests with 50 items - test_async_store_update_operations_cluster_mode: Tests delete+insert operations All tests pass with redisvl 0.9.1, confirming the fix works correctly. Fixes #96
- Add store_prefix and vector_prefix parameters to RedisStore and AsyncRedisStore - Enable multiple isolated stores in same Redis instance with custom prefixes - Replace module-level STORE_PREFIX constants with instance attributes - Fix RuntimeWarning by moving set_client_info() from BaseRedisStore to concrete implementations - Fix DeprecationWarning by replacing datetime.utcnow() with datetime.now(timezone.utc) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.