fix: resolve HITL interrupt persistence in shallow savers (#133) #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
force-pushed
the
bsb/issue-133
branch
from
c4bf53a to
e9d4b77
Compare
The shallow savers were prematurely cleaning up writes when a new checkpoint was saved, causing Human-in-the-Loop interrupts to be deleted before they could be consumed during resume. Changes: - Remove aggressive write cleanup from aput/put methods in shallow savers - Fix registry key consistency using to_storage_safe_str() for checkpoint_ns - Add comprehensive HITL integration tests (7 new tests) - Update existing tests to reflect new write persistence behavior Writes are now cleaned up only via delete_thread, TTL expiration, or explicit overwrite - not during checkpoint transitions.
bsbodden
force-pushed
the
bsb/issue-133
branch
from
e9d4b77 to
397e7f3
Compare
abrookins
approved these changes
Dec 19, 2025
Contributor
abrookins
left a comment
abrookins
left a comment
There was a problem hiding this comment.
Looks great! Nice addition of HITL integration tests. 👍 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shallow savers were prematurely cleaning up writes when a new checkpoint was saved, causing Human-in-the-Loop interrupts to be deleted before they could be consumed during resume.
Changes:
Writes are now cleaned up only via delete_thread, TTL expiration, or explicit overwrite - not during checkpoint transitions.