Skip to content

Conversation

valkirilov
Copy link
Member

Description

Rework the visuals of the inline search for the hash/list keys in the Browser page, to make it look less broken after the EUI replacement:

  • make the search input fill the available width
  • bring back the "onBlur" behavior that should close the search if you go away without typing anything
Before After
image image

How it was tested

  1. Open the Databases page and connect to an existing database (or establish a connection with a new instance)
  2. Go to the Browse tab from the main navbar
  3. Execute the following commands in the CLI, to setup some seed data that will help you verify the changes
  4. Now, you can open the seeded keys and click on the Search icon in the table
HSET myhash field1 "value1" field2 "value2" field3 "value3"
RPUSH mylist "element1" "element2" "element3"
Before After
Screenshot 2025-09-26 at 14 31 14 Screenshot 2025-09-26 at 14 31 44
Screenshot 2025-09-26 at 14 31 21 Screenshot 2025-09-26 at 14 32 07

Close the search input on blur

Additionally, I bring back an old behavior that was temporarily deleted for some reason:

  • when clicking outside of the search field, it will hide if if there is nothing entered inside it
  • and it will stay visible if you have search value applied
Screen.Recording.2025-09-26.at.14.23.15.mov

Copy link
Contributor

github-actions bot commented Sep 26, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.16% 20033/24382
🟡 Branches 67.53% 8687/12863
🟡 Functions 76.3% 5336/6993
🟢 Lines 82.58% 19613/23749

Test suite run success

5161 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from 11f9866

dantovska
dantovska previously approved these changes Sep 29, 2025
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pd-redis
pd-redis previously approved these changes Sep 29, 2025
…t keys in the browser

- make the search input to fill in all the available width
- bring back the "onBlur" behavior that should close the search if you go away without typiing anything

re #RI-7542
@valkirilov valkirilov force-pushed the fe/bugfix/RI-7542_browser-keys-search branch from 9b875db to 11f9866 Compare September 29, 2025 07:17
@valkirilov valkirilov merged commit 23e842d into main Sep 29, 2025
18 checks passed
@valkirilov valkirilov deleted the fe/bugfix/RI-7542_browser-keys-search branch September 29, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants